pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Amit Kapila <akapila@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix regression test failure caused by commit 8d74fc96db.
Date: Wed, 01 Dec 2021 07:34:37 +0000
Message-ID: <E1msK8T-0003lM-TS@gemulon.postgresql.org> (raw)

Fix regression test failure caused by commit 8d74fc96db.

The tests didn't considered that an error unrelated to apply changes, e.g.
"replication origin with OID %d is already active ...", could occur on the
table sync worker before starting to copy changes.

To make the test robust we instead need to check the expected error and
the source of error which will be either tablesync or apply worker.

In passing remove the harmless option "streaming = off" from Create
Subscription command as that is anyway the default.

Per buildfarm member sidewinder.

Author: Masahiko Sawada
Reviewed-by: Hou Zhijie, Vignesh C, Amit Kapila
Discussion: https://postgr.es/m/CAD21AoDeScrsHhLyEPYqN3sydg6PxAPVBboK=30xJfUVihNZDA@mail.gmail.com
Discussion: https://postgr.es/m/E1mrtvV-0002Gz-73@gemulon.postgresql.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/41e66fee051619ab84828814554f73556a958850

Modified Files
--------------
src/test/subscription/t/026_worker_stats.pl | 59 +++++++++++++++++------------
1 file changed, 34 insertions(+), 25 deletions(-)



view thread (2+ messages)

Message-ID: <E1msK8T-0003lM-TS@gemulon.postgresql.org>
Permalink:  ../E1msK8T-0003lM-TS@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1msK8T-0003lM-TS@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: akapila@postgresql.org
  Subject: Re: pgsql: Fix regression test failure caused by commit 8d74fc96db.
  In-Reply-To: <E1msK8T-0003lM-TS@gemulon.postgresql.org>
  References: <E1msK8T-0003lM-TS@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox