pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Warning on SET of nonexisting setting with a prefix reserved by
Date: Wed, 01 Dec 2021 14:22:32 +0000
Message-ID: <E1msQVE-00067r-2e@gemulon.postgresql.org> (raw)

Warning on SET of nonexisting setting with a prefix reserved by an extension

An extension can already de facto reserve a GUC prefix using
EmitWarningsOnPlaceholders().  But this was only checked against
settings that exist at the time the extension is loaded (or the
extension chooses to call this).  No diagnostic is given when a SET
command later uses a nonexisting setting with a custom prefix.

With this change, EmitWarningsOnPlaceholders() saves the prefixes it
reserves in a list, and SET checks when it finds a "placeholder"
setting whether it belongs to a reserved prefix and issues a warning
in that case.

Add a regression test that checks the patch using the "plpgsql"
registered prefix.

Author: Florin Irion <florin.irion@enterprisedb.com>
Discussion: https://www.postgresql.org/message-id/flat/CA+HEvJDhWuuTpGTJT9Tgbdzm4QS4EzPAwDBScWK18H2Q=FVJFw@mail....

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/75d22069e00d638d08c04e3aba71688f3fb002ed

Modified Files
--------------
src/backend/utils/misc/guc.c      | 47 +++++++++++++++++++++++++++++++++++++++
src/test/regress/expected/guc.out | 19 ++++++++++++++++
src/test/regress/sql/guc.sql      | 11 +++++++++
3 files changed, 77 insertions(+)



Message-ID: <E1msQVE-00067r-2e@gemulon.postgresql.org>
Permalink:  ../E1msQVE-00067r-2e@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1msQVE-00067r-2e@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org
  Subject: Re: pgsql: Warning on SET of nonexisting setting with a prefix reserved by
  In-Reply-To: <E1msQVE-00067r-2e@gemulon.postgresql.org>
  References: <E1msQVE-00067r-2e@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox