pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: postgres_fdw: Fix unexpected reporting of empty message. 6+ messages / 1 participants [nested] [flat]
* pgsql: postgres_fdw: Fix unexpected reporting of empty message. @ 2021-12-03 08:39 Fujii Masao <fujii@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Fujii Masao @ 2021-12-03 08:39 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org postgres_fdw: Fix unexpected reporting of empty message. pgfdw_report_error() in postgres_fdw gets a message from PGresult or PGconn to report an error received from a remote server. Previously if it could get a message from neither of them, it reported empty message unexpectedly. The cause of this issue was that pgfdw_report_error() didn't handle properly the case where no message could be obtained and its local variable message_primary was set to '\0'. This commit improves pgfdw_report_error() so that it reports the message "could not obtain ..." when it gets no message and message_primary is set to '\0'. This is the same behavior as when message_primary is NULL. dblink_res_error() in dblink has the same issue, so this commit also improves it in the same way. Back-patch to all supported branches. Author: Fujii Masao Reviewed-by: Bharath Rupireddy Discussion: https://postgr.es/m/477c16c8-7ea4-20fc-38d5-ed3a77ed616c@oss.nttdata.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/557c39bba925d553c6bb12b5e80d1964d355583b Modified Files -------------- contrib/dblink/dblink.c | 3 ++- contrib/postgres_fdw/connection.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: postgres_fdw: Fix unexpected reporting of empty message. @ 2021-12-03 08:39 Fujii Masao <fujii@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Fujii Masao @ 2021-12-03 08:39 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org postgres_fdw: Fix unexpected reporting of empty message. pgfdw_report_error() in postgres_fdw gets a message from PGresult or PGconn to report an error received from a remote server. Previously if it could get a message from neither of them, it reported empty message unexpectedly. The cause of this issue was that pgfdw_report_error() didn't handle properly the case where no message could be obtained and its local variable message_primary was set to '\0'. This commit improves pgfdw_report_error() so that it reports the message "could not obtain ..." when it gets no message and message_primary is set to '\0'. This is the same behavior as when message_primary is NULL. dblink_res_error() in dblink has the same issue, so this commit also improves it in the same way. Back-patch to all supported branches. Author: Fujii Masao Reviewed-by: Bharath Rupireddy Discussion: https://postgr.es/m/477c16c8-7ea4-20fc-38d5-ed3a77ed616c@oss.nttdata.com Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/5cb86a2622f616cbacc0c4fc05a2d34e458863b6 Modified Files -------------- contrib/dblink/dblink.c | 3 ++- contrib/postgres_fdw/connection.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: postgres_fdw: Fix unexpected reporting of empty message. @ 2021-12-03 08:39 Fujii Masao <fujii@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Fujii Masao @ 2021-12-03 08:39 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org postgres_fdw: Fix unexpected reporting of empty message. pgfdw_report_error() in postgres_fdw gets a message from PGresult or PGconn to report an error received from a remote server. Previously if it could get a message from neither of them, it reported empty message unexpectedly. The cause of this issue was that pgfdw_report_error() didn't handle properly the case where no message could be obtained and its local variable message_primary was set to '\0'. This commit improves pgfdw_report_error() so that it reports the message "could not obtain ..." when it gets no message and message_primary is set to '\0'. This is the same behavior as when message_primary is NULL. dblink_res_error() in dblink has the same issue, so this commit also improves it in the same way. Back-patch to all supported branches. Author: Fujii Masao Reviewed-by: Bharath Rupireddy Discussion: https://postgr.es/m/477c16c8-7ea4-20fc-38d5-ed3a77ed616c@oss.nttdata.com Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/f89015b63f532063560ef78bc1d0d8c166173c6d Modified Files -------------- contrib/dblink/dblink.c | 3 ++- contrib/postgres_fdw/connection.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: postgres_fdw: Fix unexpected reporting of empty message. @ 2021-12-03 08:39 Fujii Masao <fujii@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Fujii Masao @ 2021-12-03 08:39 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org postgres_fdw: Fix unexpected reporting of empty message. pgfdw_report_error() in postgres_fdw gets a message from PGresult or PGconn to report an error received from a remote server. Previously if it could get a message from neither of them, it reported empty message unexpectedly. The cause of this issue was that pgfdw_report_error() didn't handle properly the case where no message could be obtained and its local variable message_primary was set to '\0'. This commit improves pgfdw_report_error() so that it reports the message "could not obtain ..." when it gets no message and message_primary is set to '\0'. This is the same behavior as when message_primary is NULL. dblink_res_error() in dblink has the same issue, so this commit also improves it in the same way. Back-patch to all supported branches. Author: Fujii Masao Reviewed-by: Bharath Rupireddy Discussion: https://postgr.es/m/477c16c8-7ea4-20fc-38d5-ed3a77ed616c@oss.nttdata.com Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/21a86b0eba64df8188463a0e497dd323e6909e31 Modified Files -------------- contrib/dblink/dblink.c | 3 ++- contrib/postgres_fdw/connection.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: postgres_fdw: Fix unexpected reporting of empty message. @ 2021-12-03 08:39 Fujii Masao <fujii@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Fujii Masao @ 2021-12-03 08:39 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org postgres_fdw: Fix unexpected reporting of empty message. pgfdw_report_error() in postgres_fdw gets a message from PGresult or PGconn to report an error received from a remote server. Previously if it could get a message from neither of them, it reported empty message unexpectedly. The cause of this issue was that pgfdw_report_error() didn't handle properly the case where no message could be obtained and its local variable message_primary was set to '\0'. This commit improves pgfdw_report_error() so that it reports the message "could not obtain ..." when it gets no message and message_primary is set to '\0'. This is the same behavior as when message_primary is NULL. dblink_res_error() in dblink has the same issue, so this commit also improves it in the same way. Back-patch to all supported branches. Author: Fujii Masao Reviewed-by: Bharath Rupireddy Discussion: https://postgr.es/m/477c16c8-7ea4-20fc-38d5-ed3a77ed616c@oss.nttdata.com Branch ------ REL_11_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/82d1e13344985369a0f5c5d1c9e72f81d997e2ca Modified Files -------------- contrib/dblink/dblink.c | 3 ++- contrib/postgres_fdw/connection.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: postgres_fdw: Fix unexpected reporting of empty message. @ 2021-12-03 08:40 Fujii Masao <fujii@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Fujii Masao @ 2021-12-03 08:40 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org postgres_fdw: Fix unexpected reporting of empty message. pgfdw_report_error() in postgres_fdw gets a message from PGresult or PGconn to report an error received from a remote server. Previously if it could get a message from neither of them, it reported empty message unexpectedly. The cause of this issue was that pgfdw_report_error() didn't handle properly the case where no message could be obtained and its local variable message_primary was set to '\0'. This commit improves pgfdw_report_error() so that it reports the message "could not obtain ..." when it gets no message and message_primary is set to '\0'. This is the same behavior as when message_primary is NULL. dblink_res_error() in dblink has the same issue, so this commit also improves it in the same way. Back-patch to all supported branches. Author: Fujii Masao Reviewed-by: Bharath Rupireddy Discussion: https://postgr.es/m/477c16c8-7ea4-20fc-38d5-ed3a77ed616c@oss.nttdata.com Branch ------ REL_10_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/429faf9ed52d7e8c321d9b28a989efbbb7f478d0 Modified Files -------------- contrib/dblink/dblink.c | 3 ++- contrib/postgres_fdw/connection.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2021-12-03 08:40 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2021-12-03 08:39 pgsql: postgres_fdw: Fix unexpected reporting of empty message. Fujii Masao <fujii@postgresql.org> 2021-12-03 08:39 pgsql: postgres_fdw: Fix unexpected reporting of empty message. Fujii Masao <fujii@postgresql.org> 2021-12-03 08:39 pgsql: postgres_fdw: Fix unexpected reporting of empty message. Fujii Masao <fujii@postgresql.org> 2021-12-03 08:39 pgsql: postgres_fdw: Fix unexpected reporting of empty message. Fujii Masao <fujii@postgresql.org> 2021-12-03 08:39 pgsql: postgres_fdw: Fix unexpected reporting of empty message. Fujii Masao <fujii@postgresql.org> 2021-12-03 08:40 pgsql: postgres_fdw: Fix unexpected reporting of empty message. Fujii Masao <fujii@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox