pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Fujii Masao <fujii@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: postgres_fdw: Fix unexpected reporting of empty message.
Date: Fri, 03 Dec 2021 08:40:08 +0000
Message-ID: <E1mt46y-0003wm-Un@gemulon.postgresql.org> (raw)

postgres_fdw: Fix unexpected reporting of empty message.

pgfdw_report_error() in postgres_fdw gets a message from PGresult or
PGconn to report an error received from a remote server. Previously
if it could get a message from neither of them, it reported empty
message unexpectedly. The cause of this issue was that pgfdw_report_error()
didn't handle properly the case where no message could be obtained
and its local variable message_primary was set to '\0'.

This commit improves pgfdw_report_error() so that it reports the message
"could not obtain ..." when it gets no message and message_primary
is set to '\0'. This is the same behavior as when message_primary is NULL.

dblink_res_error() in dblink has the same issue, so this commit also
improves it in the same way.

Back-patch to all supported branches.

Author: Fujii Masao
Reviewed-by: Bharath Rupireddy
Discussion: https://postgr.es/m/477c16c8-7ea4-20fc-38d5-ed3a77ed616c@oss.nttdata.com

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/429faf9ed52d7e8c321d9b28a989efbbb7f478d0

Modified Files
--------------
contrib/dblink/dblink.c           | 3 ++-
contrib/postgres_fdw/connection.c | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)



view thread (6+ messages)

Message-ID: <E1mt46y-0003wm-Un@gemulon.postgresql.org>
Permalink:  ../E1mt46y-0003wm-Un@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1mt46y-0003wm-Un@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: fujii@postgresql.org
  Subject: Re: pgsql: postgres_fdw: Fix unexpected reporting of empty message.
  In-Reply-To: <E1mt46y-0003wm-Un@gemulon.postgresql.org>
  References: <E1mt46y-0003wm-Un@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox