pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Rethink pg_dump's handling of object ACLs.
Date: Mon, 06 Dec 2021 18:23:20 +0000
Message-ID: <E1muIe0-0007Mw-Pm@gemulon.postgresql.org> (raw)

Rethink pg_dump's handling of object ACLs.

Throw away most of the existing logic for this, as it was very
inefficient thanks to expensive sub-selects executed to collect
ACL data that we very possibly would have no interest in dumping.
Reduce the ACL handling in the initial per-object-type queries
to be just collection of the catalog ACL fields, as it was
originally.  Fetch pg_init_privs data separately in a single
scan of that catalog, and do the merging calculations on the
client side.  Remove the separate code path used for pre-9.6
source servers; there is no good reason to treat them differently
from newer servers that happen to have empty pg_init_privs.

Discussion: https://postgr.es/m/2273648.1634764485@sss.pgh.pa.us
Discussion: https://postgr.es/m/7d7eb6128f40401d81b3b7a898b6b4de@W2012-02.nidsa.loc

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/0c9d84427f441602425b0e18be5cfe751d1d8ebe

Modified Files
--------------
src/bin/pg_dump/dumputils.c         |  516 ++++++---------
src/bin/pg_dump/dumputils.h         |   14 +-
src/bin/pg_dump/pg_dump.c           | 1199 ++++++++++++++---------------------
src/bin/pg_dump/pg_dump.h           |   69 +-
src/bin/pg_dump/pg_dumpall.c        |   59 +-
src/fe_utils/string_utils.c         |   63 ++
src/include/fe_utils/string_utils.h |    1 +
7 files changed, 784 insertions(+), 1137 deletions(-)



Message-ID: <E1muIe0-0007Mw-Pm@gemulon.postgresql.org>
Permalink:  ../E1muIe0-0007Mw-Pm@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1muIe0-0007Mw-Pm@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Rethink pg_dump's handling of object ACLs.
  In-Reply-To: <E1muIe0-0007Mw-Pm@gemulon.postgresql.org>
  References: <E1muIe0-0007Mw-Pm@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox