pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Use return instead of exit() in configure
Date: Sun, 12 Dec 2021 19:54:50 +0000
Message-ID: <E1mwUvq-0003nf-Cq@gemulon.postgresql.org> (raw)

Use return instead of exit() in configure

Using exit() requires stdlib.h, which is not included.  Use return
instead.  Also add return type for main().

This back-patches commit 1c0cf52b3 into out-of-support branches,
pursuant to a newly-established project policy that we'll try to keep
out-of-support branches buildable on modern platforms for at least
ten major releases back, ensuring people can test pg_dump and psql
compatibility against servers that far back.  With the current
development branch being v15, that works out to keeping 9.2 and up
buildable as of today.

This fix is needed to get through 'configure' when using recent
macOS (and possibly other clang-based toolchains).  It seems to
be sufficient to get through 'check-world', although there are
annoyances such as compiler warnings, which will be dealt with
separately.

Original patch by Peter Eisentraut

Discussion: https://postgr.es/m/d0316012-ece7-7b7e-2d36-9c38cb77cb3b@enterprisedb.com

Branch
------
REL9_4_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/47fca011b88a9c0eadf2b62f6c1943deae0631c3

Modified Files
--------------
config/c-compiler.m4 |  4 +++-
config/c-library.m4  |  4 +++-
configure            | 12 +++++++++---
3 files changed, 15 insertions(+), 5 deletions(-)



view thread (6+ messages)

Message-ID: <E1mwUvq-0003nf-Cq@gemulon.postgresql.org>
Permalink:  ../E1mwUvq-0003nf-Cq@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1mwUvq-0003nf-Cq@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Use return instead of exit() in configure
  In-Reply-To: <E1mwUvq-0003nf-Cq@gemulon.postgresql.org>
  References: <E1mwUvq-0003nf-Cq@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox