pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Reformat imath.c macro to remove -Wmisleading-indentation warnin
Date: Mon, 13 Dec 2021 00:12:49 +0000
Message-ID: <E1mwYxV-0006vg-UM@gemulon.postgresql.org> (raw)

Reformat imath.c macro to remove -Wmisleading-indentation warnings.

Recent versions of gcc whine about the admittedly-completely-illegible
formatting of this macro.  We've not noticed for a few reasons:

* In v12 and up, the problem is gone thanks to 48e24ba6b.
(Back-patching that doesn't seem prudent, though, so this patch
just manually improves the macro's formatting.)

* Buildfarm animals that might have complained, such as caiman,
do not because they use --with-openssl and so don't build imath.c.

* In a manual run such as "make all check-world", you won't see the
warning because it gets buried in an install.log file.  You have to
do "make -C contrib all" or the like to see it.

I noticed this because in older branches, the last bit doesn't
happen so "check-world" actually does spew the warnings to stderr.
Maybe we should rethink how that works, because the newer behavior
is not an improvement IMO.

Back-patch down to 9.2, pursuant to newly-established project policy
about keeping out-of-support branches buildable.

Discussion: https://postgr.es/m/d0316012-ece7-7b7e-2d36-9c38cb77cb3b@enterprisedb.com

Branch
------
REL9_6_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/f420f24c0a5dee7ef35990d9a9dde4397b5d8ce7

Modified Files
--------------
contrib/pgcrypto/imath.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)



view thread (7+ messages)  latest in thread

Message-ID: <E1mwYxV-0006vg-UM@gemulon.postgresql.org>
Permalink:  ../E1mwYxV-0006vg-UM@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1mwYxV-0006vg-UM@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Reformat imath.c macro to remove -Wmisleading-indentation warnin
  In-Reply-To: <E1mwYxV-0006vg-UM@gemulon.postgresql.org>
  References: <E1mwYxV-0006vg-UM@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox