From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Disable -Wsometimes-uninitialized warnings in the 9.2 branch.
Date: Mon, 13 Dec 2021 06:28:23 +0000
Message-ID: <E1mweox-0000zc-I7@gemulon.postgresql.org> (raw)
Disable -Wsometimes-uninitialized warnings in the 9.2 branch.
In 9.2, we didn't yet teach the compiler that elog(ERROR) doesn't
return, which means that the compiler's opinion about whether
variable dereferences are reachable isn't worth much. Back-patching
the commits that fixed that seems unduly invasive, so instead silence
related complaints with a big hammer.
-Wsometimes-uninitialized is a clang-ism; gcc seems to spell
this warning option differently. However, I do not observe
any such compiler warnings in 9.2 with gcc 11.2.1, so for now
we needn't do anything for gcc.
Discussion: https://postgr.es/m/d0316012-ece7-7b7e-2d36-9c38cb77cb3b@enterprisedb.com
Branch
------
REL9_2_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/cea316881f1f109fe06243f1294313ead913b498
Modified Files
--------------
configure | 67 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
configure.in | 8 ++++++++
2 files changed, 75 insertions(+)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us
Subject: Re: pgsql: Disable -Wsometimes-uninitialized warnings in the 9.2 branch.
In-Reply-To: <E1mweox-0000zc-I7@gemulon.postgresql.org>
References: <E1mweox-0000zc-I7@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox