pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Ensure casting to typmod -1 generates a RelabelType.
6+ messages / 1 participants
[nested] [flat]

* pgsql: Ensure casting to typmod -1 generates a RelabelType.
@ 2021-12-16 20:36  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2021-12-16 20:36 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Ensure casting to typmod -1 generates a RelabelType.

Fix the code changed by commit 5c056b0c2 so that we always generate
RelabelType, not something else, for a cast to unspecified typmod.
Otherwise planner optimizations might not happen.

It appears we missed this point because the previous experiments were
done on type numeric: the parser undesirably generates a call on the
numeric() length-coercion function, but then numeric_support()
optimizes that down to a RelabelType, so that everything seems fine.
It misbehaves for types that have a non-optimized length coercion
function, such as bpchar.

Per report from John Naylor.  Back-patch to all supported branches,
as the previous patch eventually was.  Unfortunately, that no longer
includes 9.6 ... we really shouldn't put this type of change into a
nearly-EOL branch.

Discussion: https://postgr.es/m/CAFBsxsEfbFHEkouc+FSj+3K1sHipLPbEC67L0SAe-9-da8QtYg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/9c356f4b2dd8f8ff49757287e387ab1d023e4449

Modified Files
--------------
src/backend/parser/parse_coerce.c         | 10 ++++++++-
src/test/regress/expected/expressions.out | 36 +++++++++++++++++++++++++++++++
src/test/regress/sql/expressions.sql      | 16 ++++++++++++++
3 files changed, 61 insertions(+), 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Ensure casting to typmod -1 generates a RelabelType.
@ 2021-12-16 20:36  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2021-12-16 20:36 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Ensure casting to typmod -1 generates a RelabelType.

Fix the code changed by commit 5c056b0c2 so that we always generate
RelabelType, not something else, for a cast to unspecified typmod.
Otherwise planner optimizations might not happen.

It appears we missed this point because the previous experiments were
done on type numeric: the parser undesirably generates a call on the
numeric() length-coercion function, but then numeric_support()
optimizes that down to a RelabelType, so that everything seems fine.
It misbehaves for types that have a non-optimized length coercion
function, such as bpchar.

Per report from John Naylor.  Back-patch to all supported branches,
as the previous patch eventually was.  Unfortunately, that no longer
includes 9.6 ... we really shouldn't put this type of change into a
nearly-EOL branch.

Discussion: https://postgr.es/m/CAFBsxsEfbFHEkouc+FSj+3K1sHipLPbEC67L0SAe-9-da8QtYg@mail.gmail.com

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/c43d72b245ecfac9fed68363b5c682fc8958bf86

Modified Files
--------------
src/backend/parser/parse_coerce.c         | 10 ++++++++-
src/test/regress/expected/expressions.out | 36 +++++++++++++++++++++++++++++++
src/test/regress/sql/expressions.sql      | 16 ++++++++++++++
3 files changed, 61 insertions(+), 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Ensure casting to typmod -1 generates a RelabelType.
@ 2021-12-16 20:36  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2021-12-16 20:36 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Ensure casting to typmod -1 generates a RelabelType.

Fix the code changed by commit 5c056b0c2 so that we always generate
RelabelType, not something else, for a cast to unspecified typmod.
Otherwise planner optimizations might not happen.

It appears we missed this point because the previous experiments were
done on type numeric: the parser undesirably generates a call on the
numeric() length-coercion function, but then numeric_support()
optimizes that down to a RelabelType, so that everything seems fine.
It misbehaves for types that have a non-optimized length coercion
function, such as bpchar.

Per report from John Naylor.  Back-patch to all supported branches,
as the previous patch eventually was.  Unfortunately, that no longer
includes 9.6 ... we really shouldn't put this type of change into a
nearly-EOL branch.

Discussion: https://postgr.es/m/CAFBsxsEfbFHEkouc+FSj+3K1sHipLPbEC67L0SAe-9-da8QtYg@mail.gmail.com

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/da0d8a4545e639ca9c22dc2a0a10dcddcdf58761

Modified Files
--------------
src/backend/parser/parse_coerce.c         | 10 ++++++++-
src/test/regress/expected/expressions.out | 36 +++++++++++++++++++++++++++++++
src/test/regress/sql/expressions.sql      | 16 ++++++++++++++
3 files changed, 61 insertions(+), 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Ensure casting to typmod -1 generates a RelabelType.
@ 2021-12-16 20:36  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2021-12-16 20:36 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Ensure casting to typmod -1 generates a RelabelType.

Fix the code changed by commit 5c056b0c2 so that we always generate
RelabelType, not something else, for a cast to unspecified typmod.
Otherwise planner optimizations might not happen.

It appears we missed this point because the previous experiments were
done on type numeric: the parser undesirably generates a call on the
numeric() length-coercion function, but then numeric_support()
optimizes that down to a RelabelType, so that everything seems fine.
It misbehaves for types that have a non-optimized length coercion
function, such as bpchar.

Per report from John Naylor.  Back-patch to all supported branches,
as the previous patch eventually was.  Unfortunately, that no longer
includes 9.6 ... we really shouldn't put this type of change into a
nearly-EOL branch.

Discussion: https://postgr.es/m/CAFBsxsEfbFHEkouc+FSj+3K1sHipLPbEC67L0SAe-9-da8QtYg@mail.gmail.com

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/e1fd61c8cea76f1abca8d9a790f2188534724703

Modified Files
--------------
src/backend/parser/parse_coerce.c         | 10 ++++++++-
src/test/regress/expected/expressions.out | 36 +++++++++++++++++++++++++++++++
src/test/regress/sql/expressions.sql      | 16 ++++++++++++++
3 files changed, 61 insertions(+), 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Ensure casting to typmod -1 generates a RelabelType.
@ 2021-12-16 20:36  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2021-12-16 20:36 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Ensure casting to typmod -1 generates a RelabelType.

Fix the code changed by commit 5c056b0c2 so that we always generate
RelabelType, not something else, for a cast to unspecified typmod.
Otherwise planner optimizations might not happen.

It appears we missed this point because the previous experiments were
done on type numeric: the parser undesirably generates a call on the
numeric() length-coercion function, but then numeric_support()
optimizes that down to a RelabelType, so that everything seems fine.
It misbehaves for types that have a non-optimized length coercion
function, such as bpchar.

Per report from John Naylor.  Back-patch to all supported branches,
as the previous patch eventually was.  Unfortunately, that no longer
includes 9.6 ... we really shouldn't put this type of change into a
nearly-EOL branch.

Discussion: https://postgr.es/m/CAFBsxsEfbFHEkouc+FSj+3K1sHipLPbEC67L0SAe-9-da8QtYg@mail.gmail.com

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/1acf345869f73ff2e12e034f1e22ac652da0ef43

Modified Files
--------------
src/backend/parser/parse_coerce.c         | 10 ++++++++-
src/test/regress/expected/expressions.out | 36 +++++++++++++++++++++++++++++++
src/test/regress/sql/expressions.sql      | 16 ++++++++++++++
3 files changed, 61 insertions(+), 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Ensure casting to typmod -1 generates a RelabelType.
@ 2021-12-16 20:36  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2021-12-16 20:36 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Ensure casting to typmod -1 generates a RelabelType.

Fix the code changed by commit 5c056b0c2 so that we always generate
RelabelType, not something else, for a cast to unspecified typmod.
Otherwise planner optimizations might not happen.

It appears we missed this point because the previous experiments were
done on type numeric: the parser undesirably generates a call on the
numeric() length-coercion function, but then numeric_support()
optimizes that down to a RelabelType, so that everything seems fine.
It misbehaves for types that have a non-optimized length coercion
function, such as bpchar.

Per report from John Naylor.  Back-patch to all supported branches,
as the previous patch eventually was.  Unfortunately, that no longer
includes 9.6 ... we really shouldn't put this type of change into a
nearly-EOL branch.

Discussion: https://postgr.es/m/CAFBsxsEfbFHEkouc+FSj+3K1sHipLPbEC67L0SAe-9-da8QtYg@mail.gmail.com

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/f9a8bc9f27e6c7569f30fc86b82129647068f6a0

Modified Files
--------------
src/backend/parser/parse_coerce.c         | 10 ++++++++-
src/test/regress/expected/expressions.out | 36 +++++++++++++++++++++++++++++++
src/test/regress/sql/expressions.sql      | 16 ++++++++++++++
3 files changed, 61 insertions(+), 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread


end of thread, other threads:[~2021-12-16 20:36 UTC | newest]

Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-12-16 20:36 pgsql: Ensure casting to typmod -1 generates a RelabelType. Tom Lane <tgl@sss.pgh.pa.us>
2021-12-16 20:36 pgsql: Ensure casting to typmod -1 generates a RelabelType. Tom Lane <tgl@sss.pgh.pa.us>
2021-12-16 20:36 pgsql: Ensure casting to typmod -1 generates a RelabelType. Tom Lane <tgl@sss.pgh.pa.us>
2021-12-16 20:36 pgsql: Ensure casting to typmod -1 generates a RelabelType. Tom Lane <tgl@sss.pgh.pa.us>
2021-12-16 20:36 pgsql: Ensure casting to typmod -1 generates a RelabelType. Tom Lane <tgl@sss.pgh.pa.us>
2021-12-16 20:36 pgsql: Ensure casting to typmod -1 generates a RelabelType. Tom Lane <tgl@sss.pgh.pa.us>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox