pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Ensure casting to typmod -1 generates a RelabelType.
Date: Thu, 16 Dec 2021 20:36:24 +0000
Message-ID: <E1mxxUG-0006kv-U5@gemulon.postgresql.org> (raw)

Ensure casting to typmod -1 generates a RelabelType.

Fix the code changed by commit 5c056b0c2 so that we always generate
RelabelType, not something else, for a cast to unspecified typmod.
Otherwise planner optimizations might not happen.

It appears we missed this point because the previous experiments were
done on type numeric: the parser undesirably generates a call on the
numeric() length-coercion function, but then numeric_support()
optimizes that down to a RelabelType, so that everything seems fine.
It misbehaves for types that have a non-optimized length coercion
function, such as bpchar.

Per report from John Naylor.  Back-patch to all supported branches,
as the previous patch eventually was.  Unfortunately, that no longer
includes 9.6 ... we really shouldn't put this type of change into a
nearly-EOL branch.

Discussion: https://postgr.es/m/CAFBsxsEfbFHEkouc+FSj+3K1sHipLPbEC67L0SAe-9-da8QtYg@mail.gmail.com

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/1acf345869f73ff2e12e034f1e22ac652da0ef43

Modified Files
--------------
src/backend/parser/parse_coerce.c         | 10 ++++++++-
src/test/regress/expected/expressions.out | 36 +++++++++++++++++++++++++++++++
src/test/regress/sql/expressions.sql      | 16 ++++++++++++++
3 files changed, 61 insertions(+), 1 deletion(-)



view thread (6+ messages)  latest in thread

Message-ID: <E1mxxUG-0006kv-U5@gemulon.postgresql.org>
Permalink:  ../E1mxxUG-0006kv-U5@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1mxxUG-0006kv-U5@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Ensure casting to typmod -1 generates a RelabelType.
  In-Reply-To: <E1mxxUG-0006kv-U5@gemulon.postgresql.org>
  References: <E1mxxUG-0006kv-U5@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox