pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix the public schema's permissions in a separate test script.
Date: Fri, 17 Dec 2021 21:22:41 +0000
Message-ID: <E1myKgb-0006uo-Ns@gemulon.postgresql.org> (raw)

Fix the public schema's permissions in a separate test script.

In the wake of commit b073c3ccd, it's necessary to grant create
permissions on the public schema to PUBLIC to get many of the
core regression test scripts to pass.  That commit did so via the
quick-n-dirty expedient of adding the GRANT to the tablespace test,
which runs first.  This is problematic for single-machine
replication testing, though.  The least painful way to run the
regression tests on such a setup is to skip the tablespace test,
and that no longer works.

To fix, let's invent a separate "test_setup" script to run first,
and put the GRANT there.  Revert b073c3ccd's changes to
the tablespace.source files.

In the future it might be good to try to reduce coupling between
the various test scripts by having test_setup create widely-used
objects, with the goal that most of the scripts could run after
having run only test_setup.  That's going to take some effort,
so this commit just addresses my immediate pain point.

Discussion: https://postgr.es/m/1363170.1639763559@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/944dc45d1b633c4d612cdff9f15153ed609eaa35

Modified Files
--------------
src/test/regress/expected/test_setup.out  | 3 +++
src/test/regress/input/tablespace.source  | 5 +----
src/test/regress/output/tablespace.source | 4 +---
src/test/regress/parallel_schedule        | 5 ++++-
src/test/regress/sql/test_setup.sql       | 3 +++
5 files changed, 12 insertions(+), 8 deletions(-)



Message-ID: <E1myKgb-0006uo-Ns@gemulon.postgresql.org>
Permalink:  ../E1myKgb-0006uo-Ns@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1myKgb-0006uo-Ns@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Fix the public schema's permissions in a separate test script.
  In-Reply-To: <E1myKgb-0006uo-Ns@gemulon.postgresql.org>
  References: <E1myKgb-0006uo-Ns@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox