From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Add missing EmitWarningsOnPlaceholders() calls.
Date: Tue, 21 Dec 2021 17:12:46 +0000
Message-ID: <E1mzigw-00081T-FJ@gemulon.postgresql.org> (raw)
Add missing EmitWarningsOnPlaceholders() calls.
Extensions that define any custom GUCs should call
EmitWarningsOnPlaceholders after doing so, to help catch misspellings.
Many of our contrib modules hadn't gotten the memo on that, though.
Also add such calls to src/test/modules extensions that have GUCs.
While these aren't really user-facing, they should illustrate good
practice not faulty practice.
Shinya Kato
Discussion: https://postgr.es/m/524fa2c0a34f34b68fbfa90d0760d515@oss.nttdata.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/1fada5d81e6769ded832a4ca62ee9371bac3fb9f
Modified Files
--------------
contrib/auth_delay/auth_delay.c | 3 +++
contrib/pg_trgm/trgm_op.c | 2 ++
contrib/postgres_fdw/option.c | 2 ++
contrib/sepgsql/hooks.c | 2 ++
src/backend/utils/misc/guc.c | 7 +++++++
src/pl/tcl/pltcl.c | 3 +++
src/test/modules/delay_execution/delay_execution.c | 2 ++
src/test/modules/ssl_passphrase_callback/ssl_passphrase_func.c | 3 +++
src/test/modules/worker_spi/worker_spi.c | 2 ++
9 files changed, 26 insertions(+)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us
Subject: Re: pgsql: Add missing EmitWarningsOnPlaceholders() calls.
In-Reply-To: <E1mzigw-00081T-FJ@gemulon.postgresql.org>
References: <E1mzigw-00081T-FJ@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox