pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Correct comment and some documentation about REPLICA_IDENTITY_IN 6+ messages / 1 participants [nested] [flat]
* pgsql: Correct comment and some documentation about REPLICA_IDENTITY_IN @ 2021-12-22 07:39 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 6+ messages in thread From: Michael Paquier @ 2021-12-22 07:39 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Correct comment and some documentation about REPLICA_IDENTITY_INDEX catalog/pg_class.h was stating that REPLICA_IDENTITY_INDEX with a dropped index is equivalent to REPLICA_IDENTITY_DEFAULT. The code tells a different story, as it is equivalent to REPLICA_IDENTITY_NOTHING. The behavior exists since the introduction of replica identities, and fe7fd4e even added tests for this case but I somewhat forgot to fix this comment. While on it, this commit reorganizes the documentation about replica identities on the ALTER TABLE page, and a note is added about the case of dropped indexes with REPLICA_IDENTITY_INDEX. Author: Michael Paquier, Wei Wang Reviewed-by: Euler Taveira Discussion: https://postgr.es/m/OS3PR01MB6275464AD0A681A0793F56879E759@OS3PR01MB6275.jpnprd01.prod.outlook.com Backpatch-through: 10 Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/420f9ac1b77cca142d4ab7919a4f2b703c1278b8 Modified Files -------------- doc/src/sgml/ref/alter_table.sgml | 51 +++++++++++++++++++++++++++++++++------ src/include/catalog/pg_class.h | 2 +- 2 files changed, 44 insertions(+), 9 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Correct comment and some documentation about REPLICA_IDENTITY_IN @ 2021-12-22 07:39 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 6+ messages in thread From: Michael Paquier @ 2021-12-22 07:39 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Correct comment and some documentation about REPLICA_IDENTITY_INDEX catalog/pg_class.h was stating that REPLICA_IDENTITY_INDEX with a dropped index is equivalent to REPLICA_IDENTITY_DEFAULT. The code tells a different story, as it is equivalent to REPLICA_IDENTITY_NOTHING. The behavior exists since the introduction of replica identities, and fe7fd4e even added tests for this case but I somewhat forgot to fix this comment. While on it, this commit reorganizes the documentation about replica identities on the ALTER TABLE page, and a note is added about the case of dropped indexes with REPLICA_IDENTITY_INDEX. Author: Michael Paquier, Wei Wang Reviewed-by: Euler Taveira Discussion: https://postgr.es/m/OS3PR01MB6275464AD0A681A0793F56879E759@OS3PR01MB6275.jpnprd01.prod.outlook.com Backpatch-through: 10 Branch ------ REL_10_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/9edca4cb57d240a196403c805dfa92686954d155 Modified Files -------------- doc/src/sgml/ref/alter_table.sgml | 51 +++++++++++++++++++++++++++++++++------ src/include/catalog/pg_class.h | 2 +- 2 files changed, 44 insertions(+), 9 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Correct comment and some documentation about REPLICA_IDENTITY_IN @ 2021-12-22 07:39 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 6+ messages in thread From: Michael Paquier @ 2021-12-22 07:39 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Correct comment and some documentation about REPLICA_IDENTITY_INDEX catalog/pg_class.h was stating that REPLICA_IDENTITY_INDEX with a dropped index is equivalent to REPLICA_IDENTITY_DEFAULT. The code tells a different story, as it is equivalent to REPLICA_IDENTITY_NOTHING. The behavior exists since the introduction of replica identities, and fe7fd4e even added tests for this case but I somewhat forgot to fix this comment. While on it, this commit reorganizes the documentation about replica identities on the ALTER TABLE page, and a note is added about the case of dropped indexes with REPLICA_IDENTITY_INDEX. Author: Michael Paquier, Wei Wang Reviewed-by: Euler Taveira Discussion: https://postgr.es/m/OS3PR01MB6275464AD0A681A0793F56879E759@OS3PR01MB6275.jpnprd01.prod.outlook.com Backpatch-through: 10 Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/28e1e5c2a91ccc2ad8f2749f36f0ac8eb3bca759 Modified Files -------------- doc/src/sgml/ref/alter_table.sgml | 51 +++++++++++++++++++++++++++++++++------ src/include/catalog/pg_class.h | 2 +- 2 files changed, 44 insertions(+), 9 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Correct comment and some documentation about REPLICA_IDENTITY_IN @ 2021-12-22 07:39 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 6+ messages in thread From: Michael Paquier @ 2021-12-22 07:39 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Correct comment and some documentation about REPLICA_IDENTITY_INDEX catalog/pg_class.h was stating that REPLICA_IDENTITY_INDEX with a dropped index is equivalent to REPLICA_IDENTITY_DEFAULT. The code tells a different story, as it is equivalent to REPLICA_IDENTITY_NOTHING. The behavior exists since the introduction of replica identities, and fe7fd4e even added tests for this case but I somewhat forgot to fix this comment. While on it, this commit reorganizes the documentation about replica identities on the ALTER TABLE page, and a note is added about the case of dropped indexes with REPLICA_IDENTITY_INDEX. Author: Michael Paquier, Wei Wang Reviewed-by: Euler Taveira Discussion: https://postgr.es/m/OS3PR01MB6275464AD0A681A0793F56879E759@OS3PR01MB6275.jpnprd01.prod.outlook.com Backpatch-through: 10 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/fc95d35b9429096ec4d028d79dcf1fb8b5d4b16e Modified Files -------------- doc/src/sgml/ref/alter_table.sgml | 51 +++++++++++++++++++++++++++++++++------ src/include/catalog/pg_class.h | 2 +- 2 files changed, 44 insertions(+), 9 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Correct comment and some documentation about REPLICA_IDENTITY_IN @ 2021-12-22 07:39 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 6+ messages in thread From: Michael Paquier @ 2021-12-22 07:39 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Correct comment and some documentation about REPLICA_IDENTITY_INDEX catalog/pg_class.h was stating that REPLICA_IDENTITY_INDEX with a dropped index is equivalent to REPLICA_IDENTITY_DEFAULT. The code tells a different story, as it is equivalent to REPLICA_IDENTITY_NOTHING. The behavior exists since the introduction of replica identities, and fe7fd4e even added tests for this case but I somewhat forgot to fix this comment. While on it, this commit reorganizes the documentation about replica identities on the ALTER TABLE page, and a note is added about the case of dropped indexes with REPLICA_IDENTITY_INDEX. Author: Michael Paquier, Wei Wang Reviewed-by: Euler Taveira Discussion: https://postgr.es/m/OS3PR01MB6275464AD0A681A0793F56879E759@OS3PR01MB6275.jpnprd01.prod.outlook.com Backpatch-through: 10 Branch ------ REL_11_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/1a0ef5e2cc63797feec1bbbf2ca89906fed76bfb Modified Files -------------- doc/src/sgml/ref/alter_table.sgml | 51 +++++++++++++++++++++++++++++++++------ src/include/catalog/pg_class.h | 2 +- 2 files changed, 44 insertions(+), 9 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Correct comment and some documentation about REPLICA_IDENTITY_IN @ 2021-12-22 07:39 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 6+ messages in thread From: Michael Paquier @ 2021-12-22 07:39 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Correct comment and some documentation about REPLICA_IDENTITY_INDEX catalog/pg_class.h was stating that REPLICA_IDENTITY_INDEX with a dropped index is equivalent to REPLICA_IDENTITY_DEFAULT. The code tells a different story, as it is equivalent to REPLICA_IDENTITY_NOTHING. The behavior exists since the introduction of replica identities, and fe7fd4e even added tests for this case but I somewhat forgot to fix this comment. While on it, this commit reorganizes the documentation about replica identities on the ALTER TABLE page, and a note is added about the case of dropped indexes with REPLICA_IDENTITY_INDEX. Author: Michael Paquier, Wei Wang Reviewed-by: Euler Taveira Discussion: https://postgr.es/m/OS3PR01MB6275464AD0A681A0793F56879E759@OS3PR01MB6275.jpnprd01.prod.outlook.com Backpatch-through: 10 Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/861095a40987fb40d0e3ed43f223ca0f79071dea Modified Files -------------- doc/src/sgml/ref/alter_table.sgml | 51 +++++++++++++++++++++++++++++++++------ src/include/catalog/pg_class.h | 2 +- 2 files changed, 44 insertions(+), 9 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2021-12-22 07:39 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2021-12-22 07:39 pgsql: Correct comment and some documentation about REPLICA_IDENTITY_IN Michael Paquier <michael@paquier.xyz> 2021-12-22 07:39 pgsql: Correct comment and some documentation about REPLICA_IDENTITY_IN Michael Paquier <michael@paquier.xyz> 2021-12-22 07:39 pgsql: Correct comment and some documentation about REPLICA_IDENTITY_IN Michael Paquier <michael@paquier.xyz> 2021-12-22 07:39 pgsql: Correct comment and some documentation about REPLICA_IDENTITY_IN Michael Paquier <michael@paquier.xyz> 2021-12-22 07:39 pgsql: Correct comment and some documentation about REPLICA_IDENTITY_IN Michael Paquier <michael@paquier.xyz> 2021-12-22 07:39 pgsql: Correct comment and some documentation about REPLICA_IDENTITY_IN Michael Paquier <michael@paquier.xyz>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox