From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Correct comment and some documentation about REPLICA_IDENTITY_IN
Date: Wed, 22 Dec 2021 07:39:35 +0000
Message-ID: <E1mzwDn-0004bT-DL@gemulon.postgresql.org> (raw)
Correct comment and some documentation about REPLICA_IDENTITY_INDEX
catalog/pg_class.h was stating that REPLICA_IDENTITY_INDEX with a
dropped index is equivalent to REPLICA_IDENTITY_DEFAULT. The code tells
a different story, as it is equivalent to REPLICA_IDENTITY_NOTHING.
The behavior exists since the introduction of replica identities, and
fe7fd4e even added tests for this case but I somewhat forgot to fix this
comment.
While on it, this commit reorganizes the documentation about replica
identities on the ALTER TABLE page, and a note is added about the case
of dropped indexes with REPLICA_IDENTITY_INDEX.
Author: Michael Paquier, Wei Wang
Reviewed-by: Euler Taveira
Discussion: https://postgr.es/m/OS3PR01MB6275464AD0A681A0793F56879E759@OS3PR01MB6275.jpnprd01.prod.outlook.com
Backpatch-through: 10
Branch
------
REL_13_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/28e1e5c2a91ccc2ad8f2749f36f0ac8eb3bca759
Modified Files
--------------
doc/src/sgml/ref/alter_table.sgml | 51 +++++++++++++++++++++++++++++++++------
src/include/catalog/pg_class.h | 2 +-
2 files changed, 44 insertions(+), 9 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz
Subject: Re: pgsql: Correct comment and some documentation about REPLICA_IDENTITY_IN
In-Reply-To: <E1mzwDn-0004bT-DL@gemulon.postgresql.org>
References: <E1mzwDn-0004bT-DL@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox