pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Rethink handling of settings with a prefix reserved by an extens
Date: Mon, 27 Dec 2021 19:39:21 +0000
Message-ID: <E1n1vq5-0000S6-Dk@gemulon.postgresql.org> (raw)

Rethink handling of settings with a prefix reserved by an extension.

Commit 75d22069e made SET print a warning if you tried to set an
unrecognized parameter within namespace previously reserved by an
extension.  It seems better for that to be an outright error though,
for the same reason that we don't let you set unrecognized unqualified
parameter names.  In any case, the preceding implementation was
inefficient and erroneous.  Perform the check in a more appropriate
spot, and be more careful about prefix-match cases.

Discussion: https://postgr.es/m/116024.1640111629@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/2ed8a8cc5b634d33ea07d681c6b02213da07f792

Modified Files
--------------
src/backend/utils/misc/guc.c      | 96 +++++++++++++++++----------------------
src/test/regress/expected/guc.out | 36 +++++++--------
src/test/regress/sql/guc.sql      | 20 ++++----
3 files changed, 68 insertions(+), 84 deletions(-)



Message-ID: <E1n1vq5-0000S6-Dk@gemulon.postgresql.org>
Permalink:  ../E1n1vq5-0000S6-Dk@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1n1vq5-0000S6-Dk@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Rethink handling of settings with a prefix reserved by an extens
  In-Reply-To: <E1n1vq5-0000S6-Dk@gemulon.postgresql.org>
  References: <E1n1vq5-0000S6-Dk@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox