pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix index-only scan plans when not all index columns can be retu
Date: Sat, 01 Jan 2022 21:12:34 +0000
Message-ID: <E1n3lg2-0003l9-TA@gemulon.postgresql.org> (raw)

Fix index-only scan plans when not all index columns can be returned.

If an index has both returnable and non-returnable columns, and one of
the non-returnable columns is an expression using a Var that is in a
returnable column, then a query returning that expression could result
in an index-only scan plan that attempts to read the non-returnable
column, instead of recomputing the expression from the returnable
column as intended.

To fix, redefine the "indextlist" list of an IndexOnlyScan plan node
as containing null Consts in place of any non-returnable columns.
This solves the problem by preventing setrefs.c from falsely matching
to such entries.  The executor is happy since it only cares about the
exposed types of the entries, and ruleutils.c doesn't care because a
correct plan won't reference those entries.  I considered some other
ways to prevent setrefs.c from doing the wrong thing, but this way
seems good since (a) it allows a very localized fix, (b) it makes
the indextlist structure more compact in many cases, and (c) the
indextlist is now a more faithful representation of what the index AM
will actually produce, viz. nulls for any non-returnable columns.

This is easier to hit since we introduced included columns, but it's
possible to construct failing examples without that, as per the
added regression test.  Hence, back-patch to all supported branches.

Per bug #17350 from Louis Jachiet.

Discussion: https://postgr.es/m/17350-b5bdcf476e5badbb@postgresql.org

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/45ae4271410bfba0daba8e71eeb631c6f91088bb

Modified Files
--------------
src/backend/optimizer/plan/createplan.c | 53 +++++++++++++++++++++++++++++++--
src/include/nodes/plannodes.h           |  3 +-
src/test/regress/expected/gist.out      | 28 +++++++++++++++++
src/test/regress/sql/gist.sql           | 11 +++++++
4 files changed, 92 insertions(+), 3 deletions(-)



view thread (6+ messages)  latest in thread

Message-ID: <E1n3lg2-0003l9-TA@gemulon.postgresql.org>
Permalink:  ../E1n3lg2-0003l9-TA@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1n3lg2-0003l9-TA@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Fix index-only scan plans when not all index columns can be retu
  In-Reply-To: <E1n3lg2-0003l9-TA@gemulon.postgresql.org>
  References: <E1n3lg2-0003l9-TA@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox