pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Handle mixed returnable and non-returnable columns better in IOS
Date: Mon, 03 Jan 2022 21:12:21 +0000
Message-ID: <E1n4Ucv-0004LV-MI@gemulon.postgresql.org> (raw)

Handle mixed returnable and non-returnable columns better in IOS.

We can revert the code changes of commit b5febc1d1 now, because
commit 9a3ddeb51 installed a real solution for the difficulty
that b5febc1d1 just dodged, namely that the planner might pick
the wrong one of several index columns nominally containing the
same value.  It only matters which one we pick if we pick one
that's not returnable, and that mistake is now foreclosed.

Although both of the aforementioned commits were back-patched,
I don't feel a need to take any risk by back-patching this one.
The cases that it improves are very corner-ish.

Discussion: https://postgr.es/m/3179992.1641150853@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/8a2e323f208557acbfdc911516e84ec017f5a6ca

Modified Files
--------------
contrib/btree_gist/expected/inet.out  |  8 ++++----
contrib/btree_gist/sql/inet.sql       |  2 +-
src/backend/optimizer/path/indxpath.c | 15 +--------------
3 files changed, 6 insertions(+), 19 deletions(-)



Message-ID: <E1n4Ucv-0004LV-MI@gemulon.postgresql.org>
Permalink:  ../E1n4Ucv-0004LV-MI@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1n4Ucv-0004LV-MI@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Handle mixed returnable and non-returnable columns better in IOS
  In-Reply-To: <E1n4Ucv-0004LV-MI@gemulon.postgresql.org>
  References: <E1n4Ucv-0004LV-MI@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox