From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Enable routine running of citext's UTF8-specific test cases.
Date: Wed, 05 Jan 2022 18:30:21 +0000
Message-ID: <E1n5B3F-0003IY-23@gemulon.postgresql.org> (raw)
Enable routine running of citext's UTF8-specific test cases.
These test cases have been commented out since citext was invented,
because at the time we had no nice way to deal with tests that
have restrictions such as requiring UTF8 encoding. But now we do
have a convention for that, ie put them into a separate test file
with an early-exit path. So let's enable these tests to run when
their prerequisites are satisfied.
(We may have to tighten the prerequisites beyond the "encoding = UTF8
and locale != C" checks made here. But let's put it on the buildfarm
and see what blows up.)
Dag Lem
Discussion: https://postgr.es/m/ygezgoacs4e.fsf_-_@sid.nimrod.no
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/c2e8bd27519f47ff56987b30eb34a01969b9a9e8
Modified Files
--------------
contrib/citext/Makefile | 2 +-
contrib/citext/expected/citext.out | 29 ------
contrib/citext/expected/citext_1.out | 29 ------
contrib/citext/expected/citext_utf8.out | 146 ++++++++++++++++++++++++++++++
contrib/citext/expected/citext_utf8_1.out | 9 ++
contrib/citext/sql/citext.sql | 35 -------
contrib/citext/sql/citext_utf8.sql | 51 +++++++++++
7 files changed, 207 insertions(+), 94 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us
Subject: Re: pgsql: Enable routine running of citext's UTF8-specific test cases.
In-Reply-To: <E1n5B3F-0003IY-23@gemulon.postgresql.org>
References: <E1n5B3F-0003IY-23@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox