pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix thinko coming from 000f3adf
Date: Sat, 08 Jan 2022 00:13:01 +0000
Message-ID: <E1n5zLx-0005Lw-7U@gemulon.postgresql.org> (raw)

Fix thinko coming from 000f3adf

pg_basebackup.c relies on the compression level to not be 0 to decide if
compression should be used, but 000f3adf missed the fact that the
default compression (Z_DEFAULT_COMPRESSION) is -1, which would be used
if specifying --gzip without --compress.

While on it, add some coverage for --gzip, as this is rather easy to
miss.

Reported-by: Christoph Berg
Discussion: https://postgr.es/m/YdhRDMLjabtXOnhY@msg.df7cb.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d0d62262d34154965511cfda6b98609d27752d5a

Modified Files
--------------
src/bin/pg_basebackup/pg_basebackup.c        |  2 +-
src/bin/pg_basebackup/t/010_pg_basebackup.pl | 21 +++++++++++++++++----
2 files changed, 18 insertions(+), 5 deletions(-)



Message-ID: <E1n5zLx-0005Lw-7U@gemulon.postgresql.org>
Permalink:  ../E1n5zLx-0005Lw-7U@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1n5zLx-0005Lw-7U@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz
  Subject: Re: pgsql: Fix thinko coming from 000f3adf
  In-Reply-To: <E1n5zLx-0005Lw-7U@gemulon.postgresql.org>
  References: <E1n5zLx-0005Lw-7U@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox