pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: John Naylor <john.naylor@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Improve warning message in pg_signal_backend()
Date: Tue, 11 Jan 2022 17:59:52 +0000
Message-ID: <E1n7LR2-00038U-B9@gemulon.postgresql.org> (raw)

Improve warning message in pg_signal_backend()

Previously, invoking pg_terminate_backend() or pg_cancel_backend()
with the postmaster PID produced a "PID XXXX is not a PostgresSQL
server process" warning, which does not make sense. Change to
"backend process" to make the message more exact.

Nathan Bossart, based on an idea from Bharath Rupireddy with
input from Tom Lane and Euler Taveira

Discussion: https://www.postgresql.org/message-id/flat/CALj2ACW7Rr-R7mBcBQiXWPp=JV5chajjTdudLiF5YcpW-BmHhg@mail....

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/7fa945b857cc1b2964799411f1633468826861ff

Modified Files
--------------
src/backend/storage/ipc/signalfuncs.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)



Message-ID: <E1n7LR2-00038U-B9@gemulon.postgresql.org>
Permalink:  ../E1n7LR2-00038U-B9@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1n7LR2-00038U-B9@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: john.naylor@postgresql.org
  Subject: Re: pgsql: Improve warning message in pg_signal_backend()
  In-Reply-To: <E1n7LR2-00038U-B9@gemulon.postgresql.org>
  References: <E1n7LR2-00038U-B9@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox