pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Improve error message for missing extension.
Date: Tue, 11 Jan 2022 19:22:07 +0000
Message-ID: <E1n7Mid-0003gc-2t@gemulon.postgresql.org> (raw)

Improve error message for missing extension.

If we get ENOENT while trying to read an extension control file,
report that as a missing extension (with a HINT to install it)
rather than as a filesystem access problem.  The message wording
was extensively bikeshedded in hopes of pointing people to the
idea that they need to do a software installation before they
can install the extension into the current database.

Nathan Bossart, with review/wording suggestions from Daniel
Gustafsson, Chapman Flack, and myself

Discussion: https://postgr.es/m/3950D56A-4E47-48E7-BF9B-F5F22E268BE7@amazon.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/6f6943fc94ada145c0af5f62f719abad73825e5b

Modified Files
--------------
src/backend/commands/extension.c | 19 +++++++++++++++----
1 file changed, 15 insertions(+), 4 deletions(-)



Message-ID: <E1n7Mid-0003gc-2t@gemulon.postgresql.org>
Permalink:  ../E1n7Mid-0003gc-2t@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1n7Mid-0003gc-2t@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Improve error message for missing extension.
  In-Reply-To: <E1n7Mid-0003gc-2t@gemulon.postgresql.org>
  References: <E1n7Mid-0003gc-2t@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox