pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Tighten TAP tests' tracking of postmaster state some more.
Date: Thu, 20 Jan 2022 22:28:33 +0000
Message-ID: <E1nAfuz-00081q-GT@gemulon.postgresql.org> (raw)

Tighten TAP tests' tracking of postmaster state some more.

Commits 6c4a8903b et al. had a couple of deficiencies:

* The logic I added to Cluster::start to see if a PID file is present
could be fooled by a stale PID file left over from a previous
postmaster.  To fix, if we're not sure whether we expect to find a
running postmaster or not, validate the PID using "kill 0".

* 017_shm.pl has a loop in which it just issues repeated Cluster::start
calls; this will fail if some invocation fails but leaves self->_pid
set.  Per buildfarm results, the above fix is not enough to make this
safe: we might have "validated" a PID for a postmaster that exits
immediately after we look.  Hence, match each failed start call with
a stop call that will get us back to the self->_pid == undef state.
Add a fail_ok option to Cluster::stop to make this work.

Discussion: https://postgr.es/m/CA+hUKGKV6fOHvfiPt8=dOKzvswjAyLoFoJF1iQXMNpi7+hD1JQ@mail.gmail.com

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/4828a80069abc3e4b5baffe3ebffb69e6dd5bc10

Modified Files
--------------
src/test/perl/PostgresNode.pm  | 40 ++++++++++++++++++++++++++++++++++------
src/test/recovery/t/017_shm.pl |  3 +++
2 files changed, 37 insertions(+), 6 deletions(-)



view thread (6+ messages)  latest in thread

Message-ID: <E1nAfuz-00081q-GT@gemulon.postgresql.org>
Permalink:  ../E1nAfuz-00081q-GT@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1nAfuz-00081q-GT@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Tighten TAP tests' tracking of postmaster state some more.
  In-Reply-To: <E1nAfuz-00081q-GT@gemulon.postgresql.org>
  References: <E1nAfuz-00081q-GT@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox