pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Clean up recent Coverity complaints.
Date: Sun, 23 Jan 2022 17:51:44 +0000
Message-ID: <E1nBh1k-0005me-9c@gemulon.postgresql.org> (raw)

Clean up recent Coverity complaints.

Commit 5c649fe15 introduced a memory leak into pg_basebackup's
parse_compress_options.  (I simplified nearby code while at it.)

Commit 9a974cbcb introduced a memory leak into pg_dump's
binary_upgrade_set_pg_class_oids.

Coverity also complained about a call of SnapBuildProcessChange that
ignored the result, unlike every other call of that function.  This
is evidently intentional, so add a (void) cast to indicate that.
(It's also old, dating to b89e15105; I suppose the reason it showed
up now is 7a5f6b474's recent rearrangement of nearby code.)

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/353708e1fb2d8b1a34f6da2c25d4bb6633cf4493

Modified Files
--------------
src/backend/replication/logical/decode.c | 2 +-
src/bin/pg_basebackup/pg_basebackup.c    | 9 +++++++--
src/bin/pg_dump/pg_dump.c                | 3 ++-
3 files changed, 10 insertions(+), 4 deletions(-)



Message-ID: <E1nBh1k-0005me-9c@gemulon.postgresql.org>
Permalink:  ../E1nBh1k-0005me-9c@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1nBh1k-0005me-9c@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Clean up recent Coverity complaints.
  In-Reply-To: <E1nBh1k-0005me-9c@gemulon.postgresql.org>
  References: <E1nBh1k-0005me-9c@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox