pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: pg_dump: avoid useless query in binary_upgrade_set_type_oids_by_
Date: Sun, 23 Jan 2022 18:54:35 +0000
Message-ID: <E1nBi0Z-0006Hi-T7@gemulon.postgresql.org> (raw)

pg_dump: avoid useless query in binary_upgrade_set_type_oids_by_type_oid

Commit 6df7a9698 wrote appendPQExpBuffer where it should have
written printfPQExpBuffer.  This resulted in re-issuing the
previous query along with the desired one, which very accidentally
had no negative consequences except for some wasted cycles.

Back-patch to v14 where that came in.

Discussion: https://postgr.es/m/1714711.1642962663@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/ac7df108cf32e11e4bd120898ed09bd58fa5b62c

Modified Files
--------------
src/bin/pg_dump/pg_dump.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



view thread (2+ messages)

Message-ID: <E1nBi0Z-0006Hi-T7@gemulon.postgresql.org>
Permalink:  ../E1nBi0Z-0006Hi-T7@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1nBi0Z-0006Hi-T7@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: pg_dump: avoid useless query in binary_upgrade_set_type_oids_by_
  In-Reply-To: <E1nBi0Z-0006Hi-T7@gemulon.postgresql.org>
  References: <E1nBi0Z-0006Hi-T7@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox