pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Revert "graceful shutdown" changes for Windows, in back branches
6+ messages / 1 participants
[nested] [flat]

* pgsql: Revert "graceful shutdown" changes for Windows, in back branches
@ 2022-01-25 17:18  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2022-01-25 17:18 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Revert "graceful shutdown" changes for Windows, in back branches only.

This reverts commits 6051857fc and ed52c3707, but only in the back
branches.  Further testing has shown that while those changes do fix
some things, they also break others; in particular, it looks like
walreceivers fail to detect walsender-initiated connection close
reliably if the walsender shuts down this way.  We'll keep trying to
improve matters in HEAD, but it now seems unwise to push these changes
into stable releases.

Discussion: https://postgr.es/m/CA+hUKG+OeoETZQ=Qw5Ub5h3tmwQhBmDA=nuNO3KG=zWfUypFAw@mail.gmail.com

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/645c9457f296bdd674b3efc37047194db8233e66

Modified Files
--------------
src/backend/libpq/pqcomm.c | 29 +++++++----------------------
1 file changed, 7 insertions(+), 22 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Revert "graceful shutdown" changes for Windows, in back branches
@ 2022-01-25 17:18  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2022-01-25 17:18 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Revert "graceful shutdown" changes for Windows, in back branches only.

This reverts commits 6051857fc and ed52c3707, but only in the back
branches.  Further testing has shown that while those changes do fix
some things, they also break others; in particular, it looks like
walreceivers fail to detect walsender-initiated connection close
reliably if the walsender shuts down this way.  We'll keep trying to
improve matters in HEAD, but it now seems unwise to push these changes
into stable releases.

Discussion: https://postgr.es/m/CA+hUKG+OeoETZQ=Qw5Ub5h3tmwQhBmDA=nuNO3KG=zWfUypFAw@mail.gmail.com

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/bbb1caf6b22027cc85212e8b4fbf8f1d61734329

Modified Files
--------------
src/backend/libpq/pqcomm.c | 29 +++++++----------------------
1 file changed, 7 insertions(+), 22 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Revert "graceful shutdown" changes for Windows, in back branches
@ 2022-01-25 17:18  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2022-01-25 17:18 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Revert "graceful shutdown" changes for Windows, in back branches only.

This reverts commits 6051857fc and ed52c3707, but only in the back
branches.  Further testing has shown that while those changes do fix
some things, they also break others; in particular, it looks like
walreceivers fail to detect walsender-initiated connection close
reliably if the walsender shuts down this way.  We'll keep trying to
improve matters in HEAD, but it now seems unwise to push these changes
into stable releases.

Discussion: https://postgr.es/m/CA+hUKG+OeoETZQ=Qw5Ub5h3tmwQhBmDA=nuNO3KG=zWfUypFAw@mail.gmail.com

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/213c5aa3bdba5783529d3c0f103dbfadf4f93f50

Modified Files
--------------
src/backend/libpq/pqcomm.c | 29 +++++++----------------------
1 file changed, 7 insertions(+), 22 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Revert "graceful shutdown" changes for Windows, in back branches
@ 2022-01-25 17:18  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2022-01-25 17:18 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Revert "graceful shutdown" changes for Windows, in back branches only.

This reverts commits 6051857fc and ed52c3707, but only in the back
branches.  Further testing has shown that while those changes do fix
some things, they also break others; in particular, it looks like
walreceivers fail to detect walsender-initiated connection close
reliably if the walsender shuts down this way.  We'll keep trying to
improve matters in HEAD, but it now seems unwise to push these changes
into stable releases.

Discussion: https://postgr.es/m/CA+hUKG+OeoETZQ=Qw5Ub5h3tmwQhBmDA=nuNO3KG=zWfUypFAw@mail.gmail.com

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/64b2c6507e5714b5c688b9c5cc551fbedb7b3b58

Modified Files
--------------
src/backend/libpq/pqcomm.c | 29 +++++++----------------------
1 file changed, 7 insertions(+), 22 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Revert "graceful shutdown" changes for Windows, in back branches
@ 2022-01-25 17:18  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2022-01-25 17:18 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Revert "graceful shutdown" changes for Windows, in back branches only.

This reverts commits 6051857fc and ed52c3707, but only in the back
branches.  Further testing has shown that while those changes do fix
some things, they also break others; in particular, it looks like
walreceivers fail to detect walsender-initiated connection close
reliably if the walsender shuts down this way.  We'll keep trying to
improve matters in HEAD, but it now seems unwise to push these changes
into stable releases.

Discussion: https://postgr.es/m/CA+hUKG+OeoETZQ=Qw5Ub5h3tmwQhBmDA=nuNO3KG=zWfUypFAw@mail.gmail.com

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/75674c7ec1b1607e7013b5cebcb22d9c8b4b2cb6

Modified Files
--------------
src/backend/libpq/pqcomm.c | 29 +++++++----------------------
1 file changed, 7 insertions(+), 22 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Revert "graceful shutdown" changes for Windows.
@ 2022-03-22 14:19  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2022-03-22 14:19 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Revert "graceful shutdown" changes for Windows.

This reverts commits 6051857fc and ed52c3707 in HEAD (they were already
reverted in the back branches).  Further testing has shown that while
those changes do fix some things, they also break others; in particular,
it looks like walreceivers fail to detect walsender-initiated connection
close reliably if the walsender shuts down this way.  A proper fix for
this seems possible but won't be done in time for v15.

Discussion: https://postgr.es/m/CA+hUKG+OeoETZQ=Qw5Ub5h3tmwQhBmDA=nuNO3KG=zWfUypFAw@mail.gmail.com
Discussion: https://postgr.es/m/CA+hUKGKkp2XkvSe9nG+bsgkXVKCdTeGSa_TR0Qx1jafc_oqCVA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/29992a6a509b256efc4ac560a1586b51a64b2637

Modified Files
--------------
src/backend/libpq/pqcomm.c | 29 +++++++----------------------
1 file changed, 7 insertions(+), 22 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread


end of thread, other threads:[~2022-03-22 14:19 UTC | newest]

Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-01-25 17:18 pgsql: Revert "graceful shutdown" changes for Windows, in back branches Tom Lane <tgl@sss.pgh.pa.us>
2022-01-25 17:18 pgsql: Revert "graceful shutdown" changes for Windows, in back branches Tom Lane <tgl@sss.pgh.pa.us>
2022-01-25 17:18 pgsql: Revert "graceful shutdown" changes for Windows, in back branches Tom Lane <tgl@sss.pgh.pa.us>
2022-01-25 17:18 pgsql: Revert "graceful shutdown" changes for Windows, in back branches Tom Lane <tgl@sss.pgh.pa.us>
2022-01-25 17:18 pgsql: Revert "graceful shutdown" changes for Windows, in back branches Tom Lane <tgl@sss.pgh.pa.us>
2022-03-22 14:19 pgsql: Revert "graceful shutdown" changes for Windows. Tom Lane <tgl@sss.pgh.pa.us>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox