pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Revert "graceful shutdown" changes for Windows, in back branches
Date: Tue, 25 Jan 2022 17:18:06 +0000
Message-ID: <E1nCPSI-0001Hx-Qf@gemulon.postgresql.org> (raw)

Revert "graceful shutdown" changes for Windows, in back branches only.

This reverts commits 6051857fc and ed52c3707, but only in the back
branches.  Further testing has shown that while those changes do fix
some things, they also break others; in particular, it looks like
walreceivers fail to detect walsender-initiated connection close
reliably if the walsender shuts down this way.  We'll keep trying to
improve matters in HEAD, but it now seems unwise to push these changes
into stable releases.

Discussion: https://postgr.es/m/CA+hUKG+OeoETZQ=Qw5Ub5h3tmwQhBmDA=nuNO3KG=zWfUypFAw@mail.gmail.com

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/645c9457f296bdd674b3efc37047194db8233e66

Modified Files
--------------
src/backend/libpq/pqcomm.c | 29 +++++++----------------------
1 file changed, 7 insertions(+), 22 deletions(-)



view thread (6+ messages)  latest in thread

Message-ID: <E1nCPSI-0001Hx-Qf@gemulon.postgresql.org>
Permalink:  ../E1nCPSI-0001Hx-Qf@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1nCPSI-0001Hx-Qf@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Revert "graceful shutdown" changes for Windows, in back branches
  In-Reply-To: <E1nCPSI-0001Hx-Qf@gemulon.postgresql.org>
  References: <E1nCPSI-0001Hx-Qf@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox