pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Robert Haas <rhaas@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: pg_basebackup: Fix a couple of recently-introduced bugs.
Date: Thu, 27 Jan 2022 16:15:45 +0000
Message-ID: <E1nD7R3-0002XT-SL@gemulon.postgresql.org> (raw)

pg_basebackup: Fix a couple of recently-introduced bugs.

The server expects the compression level to be between 1 and 9, but
Z_DEFAULT_COMPRESSION is -1, so we must not try to send that value
to the server.

Because pg_basebackup's -R option is implemented on the client side,
it can't be used in combination with a backup target. Error out if
someone tries that, instead of silently ignoring the option.

Both issues were reported by Tushar Ahuja; patch by me.

Discussion: http://postgr.es/m/CA+TgmoaMwgdx8HxBjF8hmbohVvPL_0H5LqNrSq0uU+7BKp_Q2A@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/dabf63bc9a5b71f61c2c8712c85d33fdc06efa8c

Modified Files
--------------
src/bin/pg_basebackup/pg_basebackup.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)



view thread (5+ messages)  latest in thread

Message-ID: <E1nD7R3-0002XT-SL@gemulon.postgresql.org>
Permalink:  ../E1nD7R3-0002XT-SL@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1nD7R3-0002XT-SL@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: rhaas@postgresql.org
  Subject: Re: pgsql: pg_basebackup: Fix a couple of recently-introduced bugs.
  In-Reply-To: <E1nD7R3-0002XT-SL@gemulon.postgresql.org>
  References: <E1nD7R3-0002XT-SL@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox