pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Robert Haas <rhaas@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: pg_basebackup: Cleaner handling when compression is multiply spe
Date: Fri, 28 Jan 2022 16:51:26 +0000
Message-ID: <E1nDUT8-0003Fb-9X@gemulon.postgresql.org> (raw)

pg_basebackup: Cleaner handling when compression is multiply specified.

Tushar Ahuja discovered that if you use both --compress and --gzip,
or --compress multiple times, the last instance of one of these
options doesn't in all cases overwrite the compression level set by
an earlier option. That's not a serious bug, but it also has nothing
to recommend it. Repair.

Discussion: http://postgr.es/m/CA+TgmoZfP=rsZB_9vDGfhuNgSu_M_09UWu8SjvsP65y_1pQFCg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/51891d5a95605c4e98324731b386345d89c5a71e

Modified Files
--------------
src/bin/pg_basebackup/pg_basebackup.c | 6 ++++++
1 file changed, 6 insertions(+)



Message-ID: <E1nDUT8-0003Fb-9X@gemulon.postgresql.org>
Permalink:  ../E1nDUT8-0003Fb-9X@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1nDUT8-0003Fb-9X@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: rhaas@postgresql.org
  Subject: Re: pgsql: pg_basebackup: Cleaner handling when compression is multiply spe
  In-Reply-To: <E1nDUT8-0003Fb-9X@gemulon.postgresql.org>
  References: <E1nDUT8-0003Fb-9X@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox