pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix incorrect memory context switch in COPY TO execution
Date: Sat, 29 Jan 2022 01:23:37 +0000
Message-ID: <E1nDcSn-0006QD-N6@gemulon.postgresql.org> (raw)

Fix incorrect memory context switch in COPY TO execution

c532d15 has split the logic of COPY commands into multiple files, one
change being to move the internals of BeginCopy() to BeginCopyTo().
Originally the code was written so as we'd switch back-and-forth between
the current execution memory context and the dedicated memory context
for the COPY command, and this refactoring has introduced an extra
switch to the current memory context from the COPY context once
BeginCopyTo() is done with the past logic coming from BeginCopy().

The code was correctly doing the analyze, rewrite and planning phases in
the COPY context, but it was not assigning "copy_file" (FILE* used when
copying to a source file) and "filename" in the COPY context, making the
COPY status data inconsistent.

Author: Bharath Rupireddy
Reviewed-by: Japin Li
Discussion: https://postgr.es/m/CALj2ACWvVa69foi9jhHFY=2BuHxAoYboyE+vXQTARwxZcJnVrQ@mail.gmail.com
Backpatch-through: 14

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/b30282fccfa34238492c0f64808e7b4aa4ef72b3

Modified Files
--------------
src/backend/commands/copyto.c | 2 --
1 file changed, 2 deletions(-)



view thread (2+ messages)

Message-ID: <E1nDcSn-0006QD-N6@gemulon.postgresql.org>
Permalink:  ../E1nDcSn-0006QD-N6@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1nDcSn-0006QD-N6@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz
  Subject: Re: pgsql: Fix incorrect memory context switch in COPY TO execution
  In-Reply-To: <E1nDcSn-0006QD-N6@gemulon.postgresql.org>
  References: <E1nDcSn-0006QD-N6@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox