pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix comments about bgworker registration before MaxBackends init
Date: Sat, 29 Jan 2022 01:52:58 +0000
Message-ID: <E1nDcvC-0006ed-Jn@gemulon.postgresql.org> (raw)

Fix comments about bgworker registration before MaxBackends initialization

Since 6bc8ef0b, InitializeMaxBackends() has used max_worker_processes
instead of adapting MaxBackends to the number of background workers
registered by modules loaded in shared_preload_libraries (at this time,
bgworkers were only static, but gained dynamic capabilities as a matter
of supporting parallel queries meaning that a control cap was
necessary).

Some comments referred to the past registration logic, making them
confusing and incorrect, so fix these.

Some of the out-of-core modules that could be loaded in this path
sometimes like to manipulate dynamically some of the resource-related
GUCs for their own needs, this commit adds a note about that.

Author: Nathan Bossart
Discussion: https://postgr.es/m/20220127181815.GA551692@nathanxps13

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/5ecd0183fb6afa4a07aad71ea0e08c70f64a42a9

Modified Files
--------------
src/backend/postmaster/postmaster.c | 10 ++++------
src/backend/utils/init/postinit.c   |  5 ++---
2 files changed, 6 insertions(+), 9 deletions(-)



Message-ID: <E1nDcvC-0006ed-Jn@gemulon.postgresql.org>
Permalink:  ../E1nDcvC-0006ed-Jn@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1nDcvC-0006ed-Jn@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz
  Subject: Re: pgsql: Fix comments about bgworker registration before MaxBackends init
  In-Reply-To: <E1nDcvC-0006ed-Jn@gemulon.postgresql.org>
  References: <E1nDcvC-0006ed-Jn@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox