pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Simplify coding around path_contains_parent_reference().
Date: Mon, 31 Jan 2022 18:53:46 +0000
Message-ID: <E1nEboA-0005Ha-6z@gemulon.postgresql.org> (raw)

Simplify coding around path_contains_parent_reference().

Given the existing stipulation that path_contains_parent_reference()
must only be invoked on canonicalized paths, we can simplify things
in the wake of commit c10f830c5.  It is now only possible to see
".." at the start of a relative path.  That means we can simplify
path_contains_parent_reference() itself quite a bit, and it makes
the two existing outside call sites dead code, since they'd already
checked that the path is absolute.

We could now fold path_contains_parent_reference() into its only
remaining caller path_is_relative_and_below_cwd().  But it seems
better to leave it as a separately callable function, in case any
extensions are using it.

Also document the pre-existing requirement for
path_is_relative_and_below_cwd's input to be likewise canonicalized.

Shenhao Wang and Tom Lane

Discussion: https://postgr.es/m/OSBPR01MB4214FA221FFE046F11F2AD74F2D49@OSBPR01MB4214.jpnprd01.prod.outlook.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b426bd48ee3f5a6890038421f81df7ed919d73dc

Modified Files
--------------
contrib/adminpack/adminpack.c   |  6 ------
src/backend/utils/adt/genfile.c |  6 ------
src/port/path.c                 | 31 +++++++++++++------------------
3 files changed, 13 insertions(+), 30 deletions(-)



Message-ID: <E1nEboA-0005Ha-6z@gemulon.postgresql.org>
Permalink:  ../E1nEboA-0005Ha-6z@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1nEboA-0005Ha-6z@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Simplify coding around path_contains_parent_reference().
  In-Reply-To: <E1nEboA-0005Ha-6z@gemulon.postgresql.org>
  References: <E1nEboA-0005Ha-6z@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox