pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Robert Haas <rhaas@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix server crash bug in 'server' backup target.
Date: Wed, 02 Feb 2022 18:59:20 +0000
Message-ID: <E1nFKqe-0005qo-FY@gemulon.postgresql.org> (raw)

Fix server crash bug in 'server' backup target.

When this code executed as superuser it appeared to work because no
system catalog lookups happened, but otherwise it crashes because there
is no transaction environment. Fix that.

Report and code change by me. Test case by Dagfinn Ilmari Mannsåker.

Discussion: http://postgr.es/m/CA+TgmobiKLXne-2AVzYyWRiO8=rChBQ=7ywoxp=2SmcFw=oDDw@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/8e2b6d45a033287da7c8f63062129ea02d86d831

Modified Files
--------------
src/backend/replication/basebackup_server.c  |  3 +++
src/bin/pg_basebackup/t/010_pg_basebackup.pl | 13 ++++++++++++-
2 files changed, 15 insertions(+), 1 deletion(-)



Message-ID: <E1nFKqe-0005qo-FY@gemulon.postgresql.org>
Permalink:  ../E1nFKqe-0005qo-FY@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1nFKqe-0005qo-FY@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: rhaas@postgresql.org
  Subject: Re: pgsql: Fix server crash bug in 'server' backup target.
  In-Reply-To: <E1nFKqe-0005qo-FY@gemulon.postgresql.org>
  References: <E1nFKqe-0005qo-FY@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox