pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove configure's check for rl_completion_append_character.
Date: Thu, 03 Feb 2022 04:02:05 +0000
Message-ID: <E1nFTJt-0000sr-It@gemulon.postgresql.org> (raw)

Remove configure's check for rl_completion_append_character.

The comment for PGAC_READLINE_VARIABLES says "Readline versions < 2.1
don't have rl_completion_append_character".  It seems certain that such
versions are extinct in the wild, though; for sure there are none in the
buildfarm.  Libedit has had this variable for at least twenty years too.
Also, tab-complete.c's behavior without it is quite unfriendly, since
we'll emit a space even when completion fails; but we've had no
complaints about that.

Therefore, let's assume this variable is always there, and drop the
configure check to save a few build cycles.

Discussion: https://postgr.es/m/147685.1643858911@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/4b0e37faaf5ffe1552a07438323341c6394890da

Modified Files
--------------
config/programs.m4          | 22 ++--------------------
configure                   | 41 +----------------------------------------
src/bin/psql/tab-complete.c | 10 +---------
src/include/pg_config.h.in  |  4 ----
src/tools/msvc/Solution.pm  |  1 -
5 files changed, 4 insertions(+), 74 deletions(-)



Message-ID: <E1nFTJt-0000sr-It@gemulon.postgresql.org>
Permalink:  ../E1nFTJt-0000sr-It@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1nFTJt-0000sr-It@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Remove configure's check for rl_completion_append_character.
  In-Reply-To: <E1nFTJt-0000sr-It@gemulon.postgresql.org>
  References: <E1nFTJt-0000sr-It@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox