pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Add (void) cast in front of rmtree() call at the end of pg_upgra
Date: Mon, 07 Feb 2022 05:27:36 +0000
Message-ID: <E1nGwYq-0001Vd-D3@gemulon.postgresql.org> (raw)

Add (void) cast in front of rmtree() call at the end of pg_upgrade

Most calls of rmtree() report an error, and the code coming from 38bfae3
has introduced one caller where this is not done.  The previous behavior
was to not fail hard if any log file generated is not properly unlinked
when cleaning up the contents generated once the upgrade has completed,
so add a cast to (void) to indicate the intention behind this new code.

Per gripe from Coverity.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/42a9e88bf6a809e6023c9d50f58cc6b9446f229d

Modified Files
--------------
src/bin/pg_upgrade/pg_upgrade.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



Message-ID: <E1nGwYq-0001Vd-D3@gemulon.postgresql.org>
Permalink:  ../E1nGwYq-0001Vd-D3@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1nGwYq-0001Vd-D3@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz
  Subject: Re: pgsql: Add (void) cast in front of rmtree() call at the end of pg_upgra
  In-Reply-To: <E1nGwYq-0001Vd-D3@gemulon.postgresql.org>
  References: <E1nGwYq-0001Vd-D3@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox