pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Noah Misch <noah@leadboat.com>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Use Test::Builder::todo_start(), replacing $::TODO.
Date: Thu, 10 Feb 2022 02:17:32 +0000
Message-ID: <E1nHz1Y-0000qx-Mh@gemulon.postgresql.org> (raw)

Use Test::Builder::todo_start(), replacing $::TODO.

Some pre-2017 Test::More versions need perfect $Test::Builder::Level
maintenance to find the variable.  Buildfarm member snapper reported an
overall failure that the file intended to hide via the TODO construct.
That trouble was reachable in v11 and v10.  For later branches, this
serves as defense in depth.  Back-patch to v10 (all supported versions).

Discussion: https://postgr.es/m/20220202055556.GB2745933@rfd.leadboat.com

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/6da62ff14c57ec9ab68bc7fa590eca7b3d1bd671

Modified Files
--------------
src/bin/pgbench/t/023_cic_2pc.pl | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)



view thread (6+ messages)  latest in thread

Message-ID: <E1nHz1Y-0000qx-Mh@gemulon.postgresql.org>
Permalink:  ../E1nHz1Y-0000qx-Mh@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1nHz1Y-0000qx-Mh@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: noah@leadboat.com
  Subject: Re: pgsql: Use Test::Builder::todo_start(), replacing $::TODO.
  In-Reply-To: <E1nHz1Y-0000qx-Mh@gemulon.postgresql.org>
  References: <E1nHz1Y-0000qx-Mh@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox