pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Daniel Gustafsson <dgustafsson@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Set SNI ClientHello extension to localhost in tests
Date: Thu, 10 Feb 2022 13:29:05 +0000
Message-ID: <E1nI9VR-0004sW-J9@gemulon.postgresql.org> (raw)

Set SNI ClientHello extension to localhost in tests

The connection strings in the SSL client tests were using the host
set up from Cluster.pm which is a temporary pathname. When SNI is
enabled we pass the host to OpenSSL in order to set the server name
indication ClientHello extension via SSL_set_tlsext_host_name.

OpenSSL doesn't validate the hostname apart from checking the max
length, but LibreSSL checks for RFC 5890 conformance which results
in errors during testing as the pathname from Cluster.pm is not a
valid hostname.

Fix by setting the host explicitly to localhost, as that's closer
to the intent of the test.

Backpatch through 14 where SNI support came in.

Reported-by: Nazir Bilal Yavuz <byavuz81@gmail.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/17391-304f81bcf724b58b@postgresql.org
Backpatch-through: 14

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/6d503d2a47324c15c5b4274bf4dd016064143754

Modified Files
--------------
src/test/ssl/t/001_ssltests.pl | 6 +++---
src/test/ssl/t/002_scram.pl    | 6 +++---
src/test/ssl/t/003_sslinfo.pl  | 6 +++---
3 files changed, 9 insertions(+), 9 deletions(-)



view thread (2+ messages)  latest in thread

Message-ID: <E1nI9VR-0004sW-J9@gemulon.postgresql.org>
Permalink:  ../E1nI9VR-0004sW-J9@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1nI9VR-0004sW-J9@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: dgustafsson@postgresql.org
  Subject: Re: pgsql: Set SNI ClientHello extension to localhost in tests
  In-Reply-To: <E1nI9VR-0004sW-J9@gemulon.postgresql.org>
  References: <E1nI9VR-0004sW-J9@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox