pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Robert Haas <rhaas@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove server support for old BASE_BACKUP command syntax.
Date: Thu, 10 Feb 2022 16:28:44 +0000
Message-ID: <E1nICJI-00061F-Vz@gemulon.postgresql.org> (raw)

Remove server support for old BASE_BACKUP command syntax.

Commit 0ba281cb4bf9f5f65529dfa4c8282abb734dd454 added a new syntax
for the BASE_BACKUP command, with extensible options, but maintained
support for the legacy syntax. This isn't important for PostgreSQL,
where pg_basebackup works with older server versions but not newer
ones, but it could in theory matter for out-of-core users of the
replication protocol.

Discussion on pgsql-hackers, however, suggests that no one is aware
of any out-of-core use of the BASE_BACKUP command, and the consensus
is in favor of removing support for the old syntax to simplify the
code, so do that.

Discussion: http://postgr.es/m/CA+TgmoazKcKUWtqVa0xZqSzbKgTH+X-aw4V7GyLD68EpDLMh8A@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/9cd28c2e5f11dfeef64a14035b82e70acead65fd

Modified Files
--------------
doc/src/sgml/protocol.sgml             | 11 ----
src/backend/replication/repl_gram.y    | 97 ++--------------------------------
src/backend/replication/repl_scanner.l | 10 ----
3 files changed, 4 insertions(+), 114 deletions(-)



Message-ID: <E1nICJI-00061F-Vz@gemulon.postgresql.org>
Permalink:  ../E1nICJI-00061F-Vz@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1nICJI-00061F-Vz@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: rhaas@postgresql.org
  Subject: Re: pgsql: Remove server support for old BASE_BACKUP command syntax.
  In-Reply-To: <E1nICJI-00061F-Vz@gemulon.postgresql.org>
  References: <E1nICJI-00061F-Vz@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox