pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Don't use_physical_tlist for an IOS with non-returnable columns.
Date: Fri, 11 Feb 2022 20:24:22 +0000
Message-ID: <E1nIcSs-0007jn-Ce@gemulon.postgresql.org> (raw)

Don't use_physical_tlist for an IOS with non-returnable columns.

createplan.c tries to save a runtime projection step by specifying
a scan plan node's output as being exactly the table's columns, or
index's columns in the case of an index-only scan, if there is not a
reason to do otherwise.  This logic did not previously pay attention
to whether an index's columns are returnable.  That worked, sort of
accidentally, until commit 9a3ddeb51 taught setrefs.c to reject plans
that try to read a non-returnable column.  I have no desire to loosen
setrefs.c's new check, so instead adjust use_physical_tlist() to not
try to optimize this way when there are non-returnable column(s).

Per report from Ryan Kelly.  Like the previous patch, back-patch
to all supported branches.

Discussion: https://postgr.es/m/CAHUie24ddN+pDNw7fkhNrjrwAX=fXXfGZZEHhRuofV_N_ftaSg@mail.gmail.com

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/0778b24ced8a873b432641001d046d1dde602466

Modified Files
--------------
src/backend/optimizer/plan/createplan.c | 16 ++++++++++++++++
src/test/regress/expected/gist.out      | 16 ++++++++++++++++
src/test/regress/sql/gist.sql           |  5 +++++
3 files changed, 37 insertions(+)



view thread (6+ messages)  latest in thread

Message-ID: <E1nIcSs-0007jn-Ce@gemulon.postgresql.org>
Permalink:  ../E1nIcSs-0007jn-Ce@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1nIcSs-0007jn-Ce@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Don't use_physical_tlist for an IOS with non-returnable columns.
  In-Reply-To: <E1nIcSs-0007jn-Ce@gemulon.postgresql.org>
  References: <E1nIcSs-0007jn-Ce@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox