pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Amit Kapila <akapila@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: WAL log unchanged toasted replica identity key attributes.
Date: Mon, 14 Feb 2022 03:35:18 +0000
Message-ID: <E1nJS90-0002Gk-EJ@gemulon.postgresql.org> (raw)

WAL log unchanged toasted replica identity key attributes.

Currently, during UPDATE, the unchanged replica identity key attributes
are not logged separately because they are getting logged as part of the
new tuple. But if they are stored externally then the untoasted values are
not getting logged as part of the new tuple and logical replication won't
be able to replicate such UPDATEs. So we need to log such attributes as
part of the old_key_tuple during UPDATE.

Reported-by: Haiying Tang
Author: Dilip Kumar and Amit Kapila
Reviewed-by: Alvaro Herrera, Haiying Tang, Andres Freund
Backpatch-through: 10
Discussion: https://postgr.es/m/OS0PR01MB611342D0A92D4F4BF26C0F47FB229@OS0PR01MB6113.jpnprd01.prod.outlook.com

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/04645bbcae72c71e5bf28a7a0c96efa851e13ddb

Modified Files
--------------
contrib/test_decoding/expected/toast.out |   2 +-
doc/src/sgml/ref/alter_table.sgml        |   9 +-
src/backend/access/heap/heapam.c         | 181 ++++++++++++++++++++-----------
3 files changed, 123 insertions(+), 69 deletions(-)



view thread (6+ messages)  latest in thread

Message-ID: <E1nJS90-0002Gk-EJ@gemulon.postgresql.org>
Permalink:  ../E1nJS90-0002Gk-EJ@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1nJS90-0002Gk-EJ@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: akapila@postgresql.org
  Subject: Re: pgsql: WAL log unchanged toasted replica identity key attributes.
  In-Reply-To: <E1nJS90-0002Gk-EJ@gemulon.postgresql.org>
  References: <E1nJS90-0002Gk-EJ@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox