pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: WAL log unchanged toasted replica identity key attributes.
6+ messages / 1 participants
[nested] [flat]

* pgsql: WAL log unchanged toasted replica identity key attributes.
@ 2022-02-14 03:35 Amit Kapila <akapila@postgresql.org>
  0 siblings, 0 replies; 6+ messages in thread

From: Amit Kapila @ 2022-02-14 03:35 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

WAL log unchanged toasted replica identity key attributes.

Currently, during UPDATE, the unchanged replica identity key attributes
are not logged separately because they are getting logged as part of the
new tuple. But if they are stored externally then the untoasted values are
not getting logged as part of the new tuple and logical replication won't
be able to replicate such UPDATEs. So we need to log such attributes as
part of the old_key_tuple during UPDATE.

Reported-by: Haiying Tang
Author: Dilip Kumar and Amit Kapila
Reviewed-by: Alvaro Herrera, Haiying Tang, Andres Freund
Backpatch-through: 10
Discussion: https://postgr.es/m/OS0PR01MB611342D0A92D4F4BF26C0F47FB229@OS0PR01MB6113.jpnprd01.prod.outlook.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/5e01001ffb386aa6683fb65b918359f486625eb1

Modified Files
--------------
contrib/test_decoding/expected/toast.out |   2 +-
doc/src/sgml/ref/alter_table.sgml        |   9 +-
src/backend/access/heap/heapam.c         | 181 ++++++++++++++++++++-----------
3 files changed, 123 insertions(+), 69 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: WAL log unchanged toasted replica identity key attributes.
@ 2022-02-14 03:35 Amit Kapila <akapila@postgresql.org>
  0 siblings, 0 replies; 6+ messages in thread

From: Amit Kapila @ 2022-02-14 03:35 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

WAL log unchanged toasted replica identity key attributes.

Currently, during UPDATE, the unchanged replica identity key attributes
are not logged separately because they are getting logged as part of the
new tuple. But if they are stored externally then the untoasted values are
not getting logged as part of the new tuple and logical replication won't
be able to replicate such UPDATEs. So we need to log such attributes as
part of the old_key_tuple during UPDATE.

Reported-by: Haiying Tang
Author: Dilip Kumar and Amit Kapila
Reviewed-by: Alvaro Herrera, Haiying Tang, Andres Freund
Backpatch-through: 10
Discussion: https://postgr.es/m/OS0PR01MB611342D0A92D4F4BF26C0F47FB229@OS0PR01MB6113.jpnprd01.prod.outlook.com

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/04645bbcae72c71e5bf28a7a0c96efa851e13ddb

Modified Files
--------------
contrib/test_decoding/expected/toast.out |   2 +-
doc/src/sgml/ref/alter_table.sgml        |   9 +-
src/backend/access/heap/heapam.c         | 181 ++++++++++++++++++++-----------
3 files changed, 123 insertions(+), 69 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: WAL log unchanged toasted replica identity key attributes.
@ 2022-02-14 03:35 Amit Kapila <akapila@postgresql.org>
  0 siblings, 0 replies; 6+ messages in thread

From: Amit Kapila @ 2022-02-14 03:35 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

WAL log unchanged toasted replica identity key attributes.

Currently, during UPDATE, the unchanged replica identity key attributes
are not logged separately because they are getting logged as part of the
new tuple. But if they are stored externally then the untoasted values are
not getting logged as part of the new tuple and logical replication won't
be able to replicate such UPDATEs. So we need to log such attributes as
part of the old_key_tuple during UPDATE.

Reported-by: Haiying Tang
Author: Dilip Kumar and Amit Kapila
Reviewed-by: Alvaro Herrera, Haiying Tang, Andres Freund
Backpatch-through: 10
Discussion: https://postgr.es/m/OS0PR01MB611342D0A92D4F4BF26C0F47FB229@OS0PR01MB6113.jpnprd01.prod.outlook.com

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/caa231be97df3e4cb2667ea355562d5a5faa60c9

Modified Files
--------------
contrib/test_decoding/expected/toast.out |   2 +-
doc/src/sgml/ref/alter_table.sgml        |   9 +-
src/backend/access/heap/heapam.c         | 181 ++++++++++++++++++++-----------
3 files changed, 123 insertions(+), 69 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: WAL log unchanged toasted replica identity key attributes.
@ 2022-02-14 03:35 Amit Kapila <akapila@postgresql.org>
  0 siblings, 0 replies; 6+ messages in thread

From: Amit Kapila @ 2022-02-14 03:35 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

WAL log unchanged toasted replica identity key attributes.

Currently, during UPDATE, the unchanged replica identity key attributes
are not logged separately because they are getting logged as part of the
new tuple. But if they are stored externally then the untoasted values are
not getting logged as part of the new tuple and logical replication won't
be able to replicate such UPDATEs. So we need to log such attributes as
part of the old_key_tuple during UPDATE.

Reported-by: Haiying Tang
Author: Dilip Kumar and Amit Kapila
Reviewed-by: Alvaro Herrera, Haiying Tang, Andres Freund
Backpatch-through: 10
Discussion: https://postgr.es/m/OS0PR01MB611342D0A92D4F4BF26C0F47FB229@OS0PR01MB6113.jpnprd01.prod.outlook.com

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/ce349cf176e20b6d12b10e1d3ede339acc77b67d

Modified Files
--------------
contrib/test_decoding/expected/toast.out |   2 +-
doc/src/sgml/ref/alter_table.sgml        |   9 +-
src/backend/access/heap/heapam.c         | 181 ++++++++++++++++++++-----------
3 files changed, 123 insertions(+), 69 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: WAL log unchanged toasted replica identity key attributes.
@ 2022-02-14 03:35 Amit Kapila <akapila@postgresql.org>
  0 siblings, 0 replies; 6+ messages in thread

From: Amit Kapila @ 2022-02-14 03:35 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

WAL log unchanged toasted replica identity key attributes.

Currently, during UPDATE, the unchanged replica identity key attributes
are not logged separately because they are getting logged as part of the
new tuple. But if they are stored externally then the untoasted values are
not getting logged as part of the new tuple and logical replication won't
be able to replicate such UPDATEs. So we need to log such attributes as
part of the old_key_tuple during UPDATE.

Reported-by: Haiying Tang
Author: Dilip Kumar and Amit Kapila
Reviewed-by: Alvaro Herrera, Haiying Tang, Andres Freund
Backpatch-through: 10
Discussion: https://postgr.es/m/OS0PR01MB611342D0A92D4F4BF26C0F47FB229@OS0PR01MB6113.jpnprd01.prod.outlook.com

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/1cd5802ac69a1831b1a1c3b7c69dd99ae80f0b5b

Modified Files
--------------
contrib/test_decoding/expected/toast.out |   2 +-
doc/src/sgml/ref/alter_table.sgml        |   9 +-
src/backend/access/heap/heapam.c         | 176 ++++++++++++++++++++-----------
3 files changed, 122 insertions(+), 65 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: WAL log unchanged toasted replica identity key attributes.
@ 2022-02-14 03:35 Amit Kapila <akapila@postgresql.org>
  0 siblings, 0 replies; 6+ messages in thread

From: Amit Kapila @ 2022-02-14 03:35 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

WAL log unchanged toasted replica identity key attributes.

Currently, during UPDATE, the unchanged replica identity key attributes
are not logged separately because they are getting logged as part of the
new tuple. But if they are stored externally then the untoasted values are
not getting logged as part of the new tuple and logical replication won't
be able to replicate such UPDATEs. So we need to log such attributes as
part of the old_key_tuple during UPDATE.

Reported-by: Haiying Tang
Author: Dilip Kumar and Amit Kapila
Reviewed-by: Alvaro Herrera, Haiying Tang, Andres Freund
Backpatch-through: 10
Discussion: https://postgr.es/m/OS0PR01MB611342D0A92D4F4BF26C0F47FB229@OS0PR01MB6113.jpnprd01.prod.outlook.com

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/b5e060473273b7ef95ec919aee0c934e659dd63e

Modified Files
--------------
contrib/test_decoding/expected/toast.out |   2 +-
doc/src/sgml/ref/alter_table.sgml        |   9 +-
src/backend/access/heap/heapam.c         | 176 ++++++++++++++++++++-----------
3 files changed, 122 insertions(+), 65 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread


end of thread, other threads:[~2022-02-14 03:35 UTC | newest]

Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-02-14 03:35 pgsql: WAL log unchanged toasted replica identity key attributes. Amit Kapila <akapila@postgresql.org>
2022-02-14 03:35 pgsql: WAL log unchanged toasted replica identity key attributes. Amit Kapila <akapila@postgresql.org>
2022-02-14 03:35 pgsql: WAL log unchanged toasted replica identity key attributes. Amit Kapila <akapila@postgresql.org>
2022-02-14 03:35 pgsql: WAL log unchanged toasted replica identity key attributes. Amit Kapila <akapila@postgresql.org>
2022-02-14 03:35 pgsql: WAL log unchanged toasted replica identity key attributes. Amit Kapila <akapila@postgresql.org>
2022-02-14 03:35 pgsql: WAL log unchanged toasted replica identity key attributes. Amit Kapila <akapila@postgresql.org>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox