pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Improve subscriber's error message for wrong publication relkind
Date: Tue, 15 Feb 2022 17:21:40 +0000
Message-ID: <E1nK1WG-0008FA-Tn@gemulon.postgresql.org> (raw)

Improve subscriber's error message for wrong publication relkind.

Pre-v13 versions only support logical replication from plain tables,
while v13 and later also allow partitioned tables to be published.
If you tried to subscribe an older server to such a publication,
you got "table XXX not found on publisher", which is pretty
unhelpful/confusing.  Arrange to deliver a more on-point error
message.  As commit c314c147c did in v13, remove the relkind check
from the query WHERE clause altogether, so that "not there"
is distinguishable from "wrong relkind".

Per report from Radoslav Nedyalkov.  Patch v10-v12.

Discussion: https://postgr.es/m/2952568.1644876730@sss.pgh.pa.us

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/17a8c4c3a274e2c04bf5f564f20398deba53cd55

Modified Files
--------------
src/backend/replication/logical/tablesync.c | 21 +++++++++++++++++----
1 file changed, 17 insertions(+), 4 deletions(-)



view thread (3+ messages)

Message-ID: <E1nK1WG-0008FA-Tn@gemulon.postgresql.org>
Permalink:  ../E1nK1WG-0008FA-Tn@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1nK1WG-0008FA-Tn@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Improve subscriber's error message for wrong publication relkind
  In-Reply-To: <E1nK1WG-0008FA-Tn@gemulon.postgresql.org>
  References: <E1nK1WG-0008FA-Tn@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox