pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Reject change of output-column collation in CREATE OR REPLACE VI
Date: Tue, 15 Feb 2022 17:57:50 +0000
Message-ID: <E1nK25G-0008Qn-71@gemulon.postgresql.org> (raw)

Reject change of output-column collation in CREATE OR REPLACE VIEW.

checkViewTupleDesc() didn't get the memo that it should verify
same attcollation along with same type/typmod.  (A quick scan
did not find other similar oversights.)

Per bug #17404 from Pierre-Aurélien Georges.  On another day
I might've back-patched this, but today I'm feeling paranoid
about unnecessary behavioral changes in back branches.

Discussion: https://postgr.es/m/17404-8a4a270ef30a6709@postgresql.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/2523928b285b06242e0c669fadfc76d73bafdd66

Modified Files
--------------
src/backend/commands/view.c               | 20 ++++++++++++++++--
src/test/regress/expected/create_view.out | 34 +++++++++++++++++++------------
src/test/regress/sql/create_view.sql      | 25 +++++++++++++++--------
3 files changed, 56 insertions(+), 23 deletions(-)



Message-ID: <E1nK25G-0008Qn-71@gemulon.postgresql.org>
Permalink:  ../E1nK25G-0008Qn-71@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1nK25G-0008Qn-71@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Reject change of output-column collation in CREATE OR REPLACE VI
  In-Reply-To: <E1nK25G-0008Qn-71@gemulon.postgresql.org>
  References: <E1nK25G-0008Qn-71@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox