pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Heikki Linnakangas <heikki.linnakangas@iki.fi>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix bogus log message when starting from a cleanly shut down sta
Date: Wed, 16 Feb 2022 21:15:44 +0000
Message-ID: <E1nKReK-0008D5-9b@gemulon.postgresql.org> (raw)

Fix bogus log message when starting from a cleanly shut down state.

In commit 70e81861fa to split xlog.c, I moved the startup code that
updates the state in the control file and prints out the "database
system was not properly shut down" message to the log, but I
accidentally removed the "if (InRecovery)" check around it. As a
result, that message was printed even if the system was cleanly shut
down, also during 'initdb'.

Discussion: https://www.postgresql.org/message-id/3357075.1645031062@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/46208923446651a58c49115d17b4de6da4934c71

Modified Files
--------------
src/backend/access/transam/xlogrecovery.c | 118 ++++++++++++++++--------------
1 file changed, 62 insertions(+), 56 deletions(-)



Message-ID: <E1nKReK-0008D5-9b@gemulon.postgresql.org>
Permalink:  ../E1nKReK-0008D5-9b@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1nKReK-0008D5-9b@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: heikki.linnakangas@iki.fi
  Subject: Re: pgsql: Fix bogus log message when starting from a cleanly shut down sta
  In-Reply-To: <E1nKReK-0008D5-9b@gemulon.postgresql.org>
  References: <E1nKReK-0008D5-9b@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox