pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove all traces of tuplestore_donestoring() in the C code
Date: Thu, 17 Feb 2022 00:52:46 +0000
Message-ID: <E1nKV2M-0000yY-Q8@gemulon.postgresql.org> (raw)

Remove all traces of tuplestore_donestoring() in the C code

This routine is a no-op since dd04e95 from 2003, with a macro kept
around for compatibility purposes.  This has led to the same code
patterns being copy-pasted around for no effect, sometimes in confusing
ways like in pg_logical_slot_get_changes_guts() from logical.c where the
code was actually incorrect.

This issue has been discussed on two different threads recently, so
rather than living with this legacy, remove any uses of this routine in
the C code to simplify things.  The compatibility macro is kept to avoid
breaking any out-of-core modules that depend on it.

Reported-by: Tatsuhito Kasahara, Justin Pryzby
Author: Tatsuhito Kasahara
Discussion: https://postgr.es/m/20211217200419.GQ17618@telsasoft.com
Discussion: https://postgr.es/m/CAP0=ZVJeeYfAeRfmzqAF2Lumdiv4S4FewyBnZd4DPTrsSQKJKw@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d61a361d1aef1231db61162d99b635b89c73169d

Modified Files
--------------
contrib/dblink/dblink.c                         | 5 -----
contrib/pageinspect/brinfuncs.c                 | 2 --
contrib/pg_stat_statements/pg_stat_statements.c | 2 --
contrib/postgres_fdw/connection.c               | 7 -------
contrib/tablefunc/tablefunc.c                   | 2 --
contrib/xml2/xpath.c                            | 2 --
src/backend/access/transam/xlogfuncs.c          | 1 -
src/backend/commands/event_trigger.c            | 6 ------
src/backend/commands/extension.c                | 9 ---------
src/backend/commands/prepare.c                  | 3 ---
src/backend/foreign/foreign.c                   | 3 ---
src/backend/replication/logical/launcher.c      | 3 ---
src/backend/replication/logical/logicalfuncs.c  | 2 --
src/backend/replication/logical/origin.c        | 2 --
src/backend/replication/slotfuncs.c             | 2 --
src/backend/replication/walsender.c             | 3 ---
src/backend/storage/ipc/shmem.c                 | 2 --
src/backend/utils/adt/mcxtfuncs.c               | 3 ---
src/backend/utils/adt/pgstatfuncs.c             | 9 ---------
src/backend/utils/adt/varlena.c                 | 2 --
src/backend/utils/misc/guc.c                    | 2 --
src/backend/utils/misc/pg_config.c              | 1 -
src/backend/utils/mmgr/portalmem.c              | 3 ---
src/include/utils/tuplestore.h                  | 2 +-
24 files changed, 1 insertion(+), 77 deletions(-)



Message-ID: <E1nKV2M-0000yY-Q8@gemulon.postgresql.org>
Permalink:  ../E1nKV2M-0000yY-Q8@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1nKV2M-0000yY-Q8@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz
  Subject: Re: pgsql: Remove all traces of tuplestore_donestoring() in the C code
  In-Reply-To: <E1nKV2M-0000yY-Q8@gemulon.postgresql.org>
  References: <E1nKV2M-0000yY-Q8@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox