pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Suppress warning about stack_base_ptr with late-model GCC. 4+ messages / 1 participants [nested] [flat]
* pgsql: Suppress warning about stack_base_ptr with late-model GCC. @ 2022-02-18 03:46 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 4+ messages in thread From: Tom Lane @ 2022-02-18 03:46 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Suppress warning about stack_base_ptr with late-model GCC. GCC 12 complains that set_stack_base is storing the address of a local variable in a long-lived pointer. This is an entirely reasonable warning (indeed, it just helped us find a bug); but that behavior is intentional here. We can work around it by using __builtin_frame_address(0) instead of a specific local variable; that produces an address a dozen or so bytes different, in my testing, but we don't care about such a small difference. Maybe someday a compiler lacking that function will start to issue a similar warning, but we'll worry about that when it happens. Patch by me, per a suggestion from Andres Freund. Back-patch to v12, which is as far back as the patch will go without some pain. (Recently-established project policy would permit a back-patch as far as 9.2, but I'm disinclined to expend the work until GCC 12 is much more widespread.) Discussion: https://postgr.es/m/3773792.1645141467@sss.pgh.pa.us Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/46b738ffc2bf27c1c0bf0492f8c646c4496819dc Modified Files -------------- config/c-compiler.m4 | 22 ++++++++++++++++++++ configure | 40 +++++++++++++++++++++++++++++++++++++ configure.in | 3 +++ src/backend/postmaster/postmaster.c | 2 +- src/backend/tcop/postgres.c | 12 ++++++++++- src/backend/utils/init/miscinit.c | 11 +++++----- src/include/pg_config.h.in | 3 +++ src/tools/msvc/Solution.pm | 1 + 8 files changed, 86 insertions(+), 8 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Suppress warning about stack_base_ptr with late-model GCC. @ 2022-02-18 03:46 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 4+ messages in thread From: Tom Lane @ 2022-02-18 03:46 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Suppress warning about stack_base_ptr with late-model GCC. GCC 12 complains that set_stack_base is storing the address of a local variable in a long-lived pointer. This is an entirely reasonable warning (indeed, it just helped us find a bug); but that behavior is intentional here. We can work around it by using __builtin_frame_address(0) instead of a specific local variable; that produces an address a dozen or so bytes different, in my testing, but we don't care about such a small difference. Maybe someday a compiler lacking that function will start to issue a similar warning, but we'll worry about that when it happens. Patch by me, per a suggestion from Andres Freund. Back-patch to v12, which is as far back as the patch will go without some pain. (Recently-established project policy would permit a back-patch as far as 9.2, but I'm disinclined to expend the work until GCC 12 is much more widespread.) Discussion: https://postgr.es/m/3773792.1645141467@sss.pgh.pa.us Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/de447bb8e6fbbad19f964a2d7f04c9ccc1d06903 Modified Files -------------- config/c-compiler.m4 | 22 ++++++++++++++++++++ configure | 40 +++++++++++++++++++++++++++++++++++++ configure.ac | 3 +++ src/backend/postmaster/postmaster.c | 2 +- src/backend/tcop/postgres.c | 20 +++++++++++++------ src/backend/utils/init/miscinit.c | 11 +++++----- src/include/pg_config.h.in | 3 +++ src/tools/msvc/Solution.pm | 1 + 8 files changed, 89 insertions(+), 13 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Suppress warning about stack_base_ptr with late-model GCC. @ 2022-02-18 03:46 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 4+ messages in thread From: Tom Lane @ 2022-02-18 03:46 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Suppress warning about stack_base_ptr with late-model GCC. GCC 12 complains that set_stack_base is storing the address of a local variable in a long-lived pointer. This is an entirely reasonable warning (indeed, it just helped us find a bug); but that behavior is intentional here. We can work around it by using __builtin_frame_address(0) instead of a specific local variable; that produces an address a dozen or so bytes different, in my testing, but we don't care about such a small difference. Maybe someday a compiler lacking that function will start to issue a similar warning, but we'll worry about that when it happens. Patch by me, per a suggestion from Andres Freund. Back-patch to v12, which is as far back as the patch will go without some pain. (Recently-established project policy would permit a back-patch as far as 9.2, but I'm disinclined to expend the work until GCC 12 is much more widespread.) Discussion: https://postgr.es/m/3773792.1645141467@sss.pgh.pa.us Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/e0d4123bbcfe6d85eb3130ded4478f2135d116f2 Modified Files -------------- config/c-compiler.m4 | 22 ++++++++++++++++++++ configure | 40 +++++++++++++++++++++++++++++++++++++ configure.in | 3 +++ src/backend/postmaster/postmaster.c | 2 +- src/backend/tcop/postgres.c | 12 ++++++++++- src/backend/utils/init/miscinit.c | 8 ++++++++ src/include/pg_config.h.in | 3 +++ 7 files changed, 88 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Suppress warning about stack_base_ptr with late-model GCC. @ 2022-02-18 03:46 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 4+ messages in thread From: Tom Lane @ 2022-02-18 03:46 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Suppress warning about stack_base_ptr with late-model GCC. GCC 12 complains that set_stack_base is storing the address of a local variable in a long-lived pointer. This is an entirely reasonable warning (indeed, it just helped us find a bug); but that behavior is intentional here. We can work around it by using __builtin_frame_address(0) instead of a specific local variable; that produces an address a dozen or so bytes different, in my testing, but we don't care about such a small difference. Maybe someday a compiler lacking that function will start to issue a similar warning, but we'll worry about that when it happens. Patch by me, per a suggestion from Andres Freund. Back-patch to v12, which is as far back as the patch will go without some pain. (Recently-established project policy would permit a back-patch as far as 9.2, but I'm disinclined to expend the work until GCC 12 is much more widespread.) Discussion: https://postgr.es/m/3773792.1645141467@sss.pgh.pa.us Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/2e30d77a196810f7e9d57709a942b1826fd1bb43 Modified Files -------------- config/c-compiler.m4 | 22 ++++++++++++++++++++ configure | 40 +++++++++++++++++++++++++++++++++++++ configure.ac | 3 +++ src/backend/postmaster/postmaster.c | 2 +- src/backend/tcop/postgres.c | 12 ++++++++++- src/backend/utils/init/miscinit.c | 11 +++++----- src/include/pg_config.h.in | 3 +++ src/tools/msvc/Solution.pm | 1 + 8 files changed, 86 insertions(+), 8 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2022-02-18 03:46 UTC | newest] Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2022-02-18 03:46 pgsql: Suppress warning about stack_base_ptr with late-model GCC. Tom Lane <tgl@sss.pgh.pa.us> 2022-02-18 03:46 pgsql: Suppress warning about stack_base_ptr with late-model GCC. Tom Lane <tgl@sss.pgh.pa.us> 2022-02-18 03:46 pgsql: Suppress warning about stack_base_ptr with late-model GCC. Tom Lane <tgl@sss.pgh.pa.us> 2022-02-18 03:46 pgsql: Suppress warning about stack_base_ptr with late-model GCC. Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox