pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Suppress warning about stack_base_ptr with late-model GCC.
Date: Fri, 18 Feb 2022 03:46:24 +0000
Message-ID: <E1nKuDw-0002F6-8u@gemulon.postgresql.org> (raw)

Suppress warning about stack_base_ptr with late-model GCC.

GCC 12 complains that set_stack_base is storing the address of
a local variable in a long-lived pointer.  This is an entirely
reasonable warning (indeed, it just helped us find a bug);
but that behavior is intentional here.  We can work around it
by using __builtin_frame_address(0) instead of a specific local
variable; that produces an address a dozen or so bytes different,
in my testing, but we don't care about such a small difference.
Maybe someday a compiler lacking that function will start to issue
a similar warning, but we'll worry about that when it happens.

Patch by me, per a suggestion from Andres Freund.  Back-patch to
v12, which is as far back as the patch will go without some pain.
(Recently-established project policy would permit a back-patch as
far as 9.2, but I'm disinclined to expend the work until GCC 12
is much more widespread.)

Discussion: https://postgr.es/m/3773792.1645141467@sss.pgh.pa.us

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/2e30d77a196810f7e9d57709a942b1826fd1bb43

Modified Files
--------------
config/c-compiler.m4                | 22 ++++++++++++++++++++
configure                           | 40 +++++++++++++++++++++++++++++++++++++
configure.ac                        |  3 +++
src/backend/postmaster/postmaster.c |  2 +-
src/backend/tcop/postgres.c         | 12 ++++++++++-
src/backend/utils/init/miscinit.c   | 11 +++++-----
src/include/pg_config.h.in          |  3 +++
src/tools/msvc/Solution.pm          |  1 +
8 files changed, 86 insertions(+), 8 deletions(-)



view thread (4+ messages)

Message-ID: <E1nKuDw-0002F6-8u@gemulon.postgresql.org>
Permalink:  ../E1nKuDw-0002F6-8u@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1nKuDw-0002F6-8u@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Suppress warning about stack_base_ptr with late-model GCC.
  In-Reply-To: <E1nKuDw-0002F6-8u@gemulon.postgresql.org>
  References: <E1nKuDw-0002F6-8u@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox