pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Add support for building with ZSTD.
4+ messages / 3 participants
[nested] [flat]

Commits from this thread:
  2022-02-21 bf4ed12b58  doc: Mention environment variable ZSTD in the TAP tests for MSVC
* pgsql: Add support for building with ZSTD.
@ 2022-02-18 18:53 Robert Haas <rhaas@postgresql.org>
  2022-02-19 06:18 ` Re: pgsql: Add support for building with ZSTD. Michael Paquier <michael@paquier.xyz>
  0 siblings, 1 reply; 4+ messages in thread

From: Robert Haas @ 2022-02-18 18:53 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Add support for building with ZSTD.

This commit doesn't actually add anything that uses ZSTD; that will be
done separately. It just puts the basic infrastructure into place.

Jeevan Ladhe, Robert Haas, and Michael Paquier. Reviewed by Justin
Pryzby and Andres Freund.

Discussion: http://postgr.es/m/CA+TgmoatQKGd+8SjcV+bzvw4XaoEwminHjU83yG12+NXtQzTTQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/6c417bbcc8ff98875234ca269979fc7defde58e5

Modified Files
--------------
configure                         | 265 ++++++++++++++++++++++++++++++++++++++
configure.ac                      |  33 +++++
doc/src/sgml/install-windows.sgml |   9 ++
doc/src/sgml/installation.sgml    |   9 ++
src/Makefile.global.in            |   1 +
src/include/pg_config.h.in        |   6 +
src/tools/msvc/Solution.pm        |  13 ++
src/tools/msvc/config_default.pl  |   1 +
src/tools/msvc/vcregress.pl       |   1 +
9 files changed, 338 insertions(+)



^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* Re: pgsql: Add support for building with ZSTD.
  2022-02-18 18:53 pgsql: Add support for building with ZSTD. Robert Haas <rhaas@postgresql.org>
@ 2022-02-19 06:18 ` Michael Paquier <michael@paquier.xyz>
  2022-02-20 14:45   ` Re: pgsql: Add support for building with ZSTD. Robert Haas <robertmhaas@gmail.com>
  0 siblings, 1 reply; 4+ messages in thread

From: Michael Paquier @ 2022-02-19 06:18 UTC (permalink / raw)
  To: Robert Haas <rhaas@postgresql.org>; +Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>

Hi,

On Fri, Feb 18, 2022 at 06:53:10PM +0000, Robert Haas wrote:
> Add support for building with ZSTD.
> 
> This commit doesn't actually add anything that uses ZSTD; that will be
> done separately. It just puts the basic infrastructure into place.
> 
> Jeevan Ladhe, Robert Haas, and Michael Paquier. Reviewed by Justin
> Pryzby and Andres Freund.

I completely forgot that the section of the docs dedicated to the TAP
tests with MSVC also needs a refresh to mention the new variable ZSTD,
as of the attached.  Do you mind if I apply that?

Thanks,
--
Michael

Attachments:

doc-zstd-msvc.patch (text/x-diff, 685B) download diff --git a/doc/src/sgml/install-windows.sgml b/doc/src/sgml/install-windows.sgml index 98fa6962f6..91b1410e4a 100644 --- a/doc/src/sgml/install-windows.sgml +++ b/doc/src/sgml/install-windows.sgml @@ -557,6 +557,15 @@ $ENV{PROVE_TESTS}='t/020*.pl t/010*.pl' <varname>PATH</varname>. </para></listitem> </varlistentry> + + <varlistentry> + <term><varname>ZSTD</varname></term> + <listitem><para> + Path to a <application>zstd</application> command. The default is + <literal>zstd</literal>, that would be the command found in + <varname>PATH</varname>. + </para></listitem> + </varlistentry> </variablelist> </para> </sect2>
signature.asc (application/pgp-signature, 832B) download ^ permalink raw reply [nested|flat] 4+ messages in thread

* Re: pgsql: Add support for building with ZSTD.
  2022-02-18 18:53 pgsql: Add support for building with ZSTD. Robert Haas <rhaas@postgresql.org>
  2022-02-19 06:18 ` Re: pgsql: Add support for building with ZSTD. Michael Paquier <michael@paquier.xyz>
@ 2022-02-20 14:45   ` Robert Haas <robertmhaas@gmail.com>
  2022-02-21 01:02     ` Re: pgsql: Add support for building with ZSTD. Michael Paquier <michael@paquier.xyz>
  0 siblings, 1 reply; 4+ messages in thread

From: Robert Haas @ 2022-02-20 14:45 UTC (permalink / raw)
  To: Michael Paquier <michael@paquier.xyz>; +Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>

On Sat, Feb 19, 2022 at 1:19 AM Michael Paquier <michael@paquier.xyz> wrote:
> On Fri, Feb 18, 2022 at 06:53:10PM +0000, Robert Haas wrote:
> > Add support for building with ZSTD.
> >
> > This commit doesn't actually add anything that uses ZSTD; that will be
> > done separately. It just puts the basic infrastructure into place.
> >
> > Jeevan Ladhe, Robert Haas, and Michael Paquier. Reviewed by Justin
> > Pryzby and Andres Freund.
>
> I completely forgot that the section of the docs dedicated to the TAP
> tests with MSVC also needs a refresh to mention the new variable ZSTD,
> as of the attached.  Do you mind if I apply that?

No issues at all with you adjusting this, but I think that sentence
reads a little awkwardly. Perhaps instead of "The default is
<literal>zstd</literal>, that would be the command found in
<varname>PATH</varname>." you could write something like "The default
is <literal>zstd</literal>, which will search for a command by that
name in the configured <varname>PATH</varname>." Or maybe something
else is better, not sure exactly, your version just seems a little odd
to me.

-- 
Robert Haas
EDB: http://www.enterprisedb.com





^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* Re: pgsql: Add support for building with ZSTD.
  2022-02-18 18:53 pgsql: Add support for building with ZSTD. Robert Haas <rhaas@postgresql.org>
  2022-02-19 06:18 ` Re: pgsql: Add support for building with ZSTD. Michael Paquier <michael@paquier.xyz>
  2022-02-20 14:45   ` Re: pgsql: Add support for building with ZSTD. Robert Haas <robertmhaas@gmail.com>
@ 2022-02-21 01:02     ` Michael Paquier <michael@paquier.xyz>
  0 siblings, 0 replies; 4+ messages in thread

From: Michael Paquier @ 2022-02-21 01:02 UTC (permalink / raw)
  To: Robert Haas <robertmhaas@gmail.com>; +Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>

On Sun, Feb 20, 2022 at 09:45:05AM -0500, Robert Haas wrote:
> No issues at all with you adjusting this, but I think that sentence
> reads a little awkwardly.

Thanks.

> Perhaps instead of "The default is
> <literal>zstd</literal>, that would be the command found in
> <varname>PATH</varname>." you could write something like "The default
> is <literal>zstd</literal>, which will search for a command by that
> name in the configured <varname>PATH</varname>." Or maybe something
> else is better, not sure exactly, your version just seems a little odd
> to me.

Okay, done then.  We've been using the same wording for all the other
variables, and what you are suggesting here sounds much better to me,
so I have adjusted all the descriptions this way, and added the ZSTD
part.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

^ permalink  raw  reply  [nested|flat] 4+ messages in thread


end of thread, other threads:[~2022-02-21 01:02 UTC | newest]

Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-02-18 18:53 pgsql: Add support for building with ZSTD. Robert Haas <rhaas@postgresql.org>
2022-02-19 06:18 ` Michael Paquier <michael@paquier.xyz>
2022-02-20 14:45   ` Robert Haas <robertmhaas@gmail.com>
2022-02-21 01:02     ` Michael Paquier <michael@paquier.xyz>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox