From: Michael Paquier <michael@paquier.xyz>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pgsql: Add support for building with ZSTD.
Date: Mon, 21 Feb 2022 10:02:58 +0900
Message-ID: <YhLkwodatZTnoHO4@paquier.xyz> (raw)
In-Reply-To: <CA+TgmoZLtMURjevDpzGQyW46GUdTJNRemNujxkBQR_KMuOTKMg@mail.gmail.com>
References: <E1nL8NS-0007eH-9y@gemulon.postgresql.org>
<YhCL0fKnDv/Zvtuo@paquier.xyz>
<CA+TgmoZLtMURjevDpzGQyW46GUdTJNRemNujxkBQR_KMuOTKMg@mail.gmail.com>
On Sun, Feb 20, 2022 at 09:45:05AM -0500, Robert Haas wrote:
> No issues at all with you adjusting this, but I think that sentence
> reads a little awkwardly.
Thanks.
> Perhaps instead of "The default is
> <literal>zstd</literal>, that would be the command found in
> <varname>PATH</varname>." you could write something like "The default
> is <literal>zstd</literal>, which will search for a command by that
> name in the configured <varname>PATH</varname>." Or maybe something
> else is better, not sure exactly, your version just seems a little odd
> to me.
Okay, done then. We've been using the same wording for all the other
variables, and what you are suggesting here sounds much better to me,
so I have adjusted all the descriptions this way, and added the ZSTD
part.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, robertmhaas@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Add support for building with ZSTD.
In-Reply-To: <YhLkwodatZTnoHO4@paquier.xyz>
References: <E1nL8NS-0007eH-9y@gemulon.postgresql.org> <YhCL0fKnDv/Zvtuo@paquier.xyz> <CA+TgmoZLtMURjevDpzGQyW46GUdTJNRemNujxkBQR_KMuOTKMg@mail.gmail.com> <YhLkwodatZTnoHO4@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox