From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Reset conn->errorReported when PQrequestCancel sets errorMessage
Date: Sun, 20 Feb 2022 20:02:47 +0000
Message-ID: <E1nLsPv-0007vD-2A@gemulon.postgresql.org> (raw)
Reset conn->errorReported when PQrequestCancel sets errorMessage.
Oversight in commit 618c16707. This is mainly neatnik-ism, since
if PQrequestCancel is used per its API contract, we should perform
pqClearConnErrorState before reaching any place that would consult
errorReported. But still, it seems like a bad idea to potentially
leave errorReported pointing past errorMessage.len.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/83a7637e2c5be27a0788b920501dde284b3fca33
Modified Files
--------------
src/interfaces/libpq/fe-connect.c | 4 ++++
1 file changed, 4 insertions(+)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us
Subject: Re: pgsql: Reset conn->errorReported when PQrequestCancel sets errorMessage
In-Reply-To: <E1nLsPv-0007vD-2A@gemulon.postgresql.org>
References: <E1nLsPv-0007vD-2A@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox