From: Andres Freund <andres@anarazel.de>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: pg_upgrade: Don't print progress status when output is not a tty
Date: Mon, 21 Feb 2022 16:35:27 +0000
Message-ID: <E1nMBeq-0000bv-7E@gemulon.postgresql.org> (raw)
pg_upgrade: Don't print progress status when output is not a tty.
Until this change pg_upgrade with output redirected to a file / pipe would end
up printing all files in the cluster. This has made check-world output
exceedingly verbose.
Author: Andres Freund <andres@anarazel.de>
Reviewed-By: Justin Pryzby <pryzby@telsasoft.com>
Reviewed-By: Daniel Gustafsson <daniel@yesql.se>
Discussion: https://postgr.es/m/CA+hUKGKjrV61ZVJ8OSag+3rKRmCZXPc03bDyWMqhXg3rdZ=fOw@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/27b02e070fd1b6622b10937d9346b65ffacbc351
Modified Files
--------------
src/bin/pg_upgrade/dump.c | 2 +-
src/bin/pg_upgrade/option.c | 2 ++
src/bin/pg_upgrade/pg_upgrade.c | 2 +-
src/bin/pg_upgrade/pg_upgrade.h | 2 ++
src/bin/pg_upgrade/relfilenode.c | 6 ++--
src/bin/pg_upgrade/util.c | 61 ++++++++++++++++++++++++++++++++--------
6 files changed, 59 insertions(+), 16 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: andres@anarazel.de
Subject: Re: pgsql: pg_upgrade: Don't print progress status when output is not a tty
In-Reply-To: <E1nMBeq-0000bv-7E@gemulon.postgresql.org>
References: <E1nMBeq-0000bv-7E@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox